[debian-mysql] Bug#504108: mysql-dfsg-5.0: DEB_BUILD_OPTION incorrectly tested for "nocheck"

[Stephen Depooter]

Package: mysql-dfsg-5.0
Severity: normal

The mysql source package uses the following snippet to see if the nocheck DEB_BUILD_OPTION is set:

ifeq ($(findstring $(DEB_BUILD_OPTIONS),nocheck),)
	if [ ! -f testsuite-stamp ] ; then \
		$(MAKE) $(MAKE_TEST_TARGET) || $(TESTSUITE_FAIL_CMD) ; \
	fi
endif

This test is incorrect since the order of the parameters is reversed.  The findstring function looks to value if the first parameter as a substring of the second parameter.  As a result, this check will fail if more than one option is specified in DEB_BUILD_OPTIONS.  Reversing the arguments should cause the desired behaviour to happen in all cases.

Thanks



-- System Information:
Debian Release: lenny/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.26-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=locale: Cannot set LC_CTYPE to default locale: No such file or directory
locale: Cannot set LC_MESSAGES to default locale: No such file or directory
locale: Cannot set LC_ALL to default locale: No such file or directory
ANSI_X3.4-1968) (ignored: LC_ALL set to en_US.UTF-8)
Shell: /bin/sh linked to /bin/bash