[debian-mysql] d/rules file issues shared among MySQL 5.5, 5.6 and MariaDB 5.5 packaing

[Otto Kekäläinen]

Hello!

I have some of questions/issues regarding certain common parts in the
rules file. Please comment so I feel better about making certain
changes :)

I'll be using the line numbering of
http://anonscm.debian.org/cgit/pkg-mysql/mysql-5.6.git/tree/debian/rules
as coordinates.


1)
> PACKAGE:=mysql-5.6

Why is this defined? Where is it used? Not at least later in the same
rules file. I don't have one for MariaDB and everything seems to work
well.


2)
> export MYSQL_BUILD_CC=$(DEB_HOST_GNU_TYPE)-gcc
> export MYSQL_BUILD_CXX=$(DEB_HOST_GNU_TYPE)-g++

Why are this exported instead of usual := syntax?
(MYSQL_BUILD_CXX := $(DEB_HOST_GNU_TYPE)-g++)


3)
> # This causes seg11 crashes if LDAP is used for groups in /etc/nsswitch.conf
> # so it is disabled by default although, according to MySQL, it brings >10%
> # performance gain if enabled. See #299382.
> ifeq ($(STATIC_MYSQLD), 1)
>    USE_STATIC_MYSQLD:=--with-mysqld-ldflags=-all-static
> endif

Has anybody tried this lately? Should we re-visit the issue
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=299382 from 2005 and
enable this performance boost again?


4)
> override_dh_auto_clean:
> @echo "RULES.$@"
> dh_testdir
> dh_testroot
> [ ! -d mysql-test/var ] || rm -rf mysql-test/var
> rm -rf $(BUILDDIR) $(BUILDDIR_PIC)
>debconf-updatepo

Why is updatepo as a part of the clean rule?


5)
> override_dh_auto_install: auto_install-stamp
>
> auto_install-stamp:

Why do we define alone stamps and then directly execute them? Why not
simply have the contents of the lone stamps directly under the dh
override?


6)
Why is the make build starting from line 88 run inside sh -c and not
directly as is?


7)
> dh_installlogrotate --name mysql-server
and
> dh_installcron --name mysql-server

Do you think the MariaDB packages should here define mariadb-server?


8)
>  get-orig-source:

What tool uses this target? Can we simply skip it and use the contents
of the watchfile instead?