[debian-mysql] MySQL in Jessie

[Norvald H. Ryeng]

On Wed, 27 Aug 2014 13:39:37 +0200, Bjoern Boschman <bjoern at boschman.de>  
wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Am 27.08.2014 13:17, schrieb Norvald H. Ryeng:
>>> Sounds like we need to get on our horses and get this moving
>>> ASAP. Unfortunately I've no time in the next 2 weeks to
>>> contribute. So all I can do is crack the whip. :-P
>>
>> As I understand it, Robie and Björn already have everything ready.
>> If I'm wrong and there's still something missing, I'd be happy to
>> help out. Robie? Björn?
>
> http://anonscm.debian.org/cgit/pkg-mysql/mysql-5.6.git/
> review and upload :)

Hi Björn,

I promised you a review. Here it is.

The package builds and works as expected, but I found some
opportunities for cleanup. I've attached a patch with the changes I
suggest, but there are a few things I don't know the exact solution
to, see below.

There are some unused CMake options that look like remnants from 5.5
packaging:

> CMake Warning:
>   Manually-specified variables were not used by the project:
>    HAVE_EMBEDDED_PRIVILEGE_CONTROL

No such option, just remove it.

>     LINUX_NATIVE_AIO

No such option. This is detected automatically. Just remove it.

>     MYSQL_USER

No such option, just remove it.

>     WITH_LIBEDIT
>     WITH_READLINE

This has changed from 5.5 to 5.6. These two options no longer
exist. The option WITH_EDITLINE should be set to either "system" or
"bundled". We want to use "system" and add libedit2 as a dependency
for mysql-client-core-5.6 (handled by dh_shlibdeps) and libedit-dev as
a build dependency.

Then there are some lintian errors:

> Now running lintian...
> E: mysql-5.6 source: build-depends-on-obsolete-package build-depends:  
> hardening-wrapper => use dpkg-buildflags instead

I tried reading the documentation. If I understand correctly, since
we're using dh v9, we don't need to do anything about this, except
removing the hardening-wrapper dependency and DEB_BUILD_HARDENING=1
 from debian/rules. Or am I mistaken? I didn't do anything about this
in the patch since I'm not sure.

> W: mysql-5.6 source: changelog-should-mention-nmu
> W: mysql-5.6 source: source-nmu-has-incorrect-version-number  
> 5.6.20-1~exp1
> W: mysql-5.6 source: ancient-standards-version 3.9.3 (current is 3.9.5)
> E: libmysqlclient18: malformed-override Possibly wrong package in  
> override at line 3 (got libmysqlclient18.1, expected libmysqlclient18)
> E: libmysqlclient18: malformed-override Possibly wrong package in  
> override at line 6 (got libmysqlclient18.1, expected libmysqlclient18)
> E: libmysqlclient18: malformed-override Possibly wrong package in  
> override at line 7 (got libmysqlclient18.1, expected libmysqlclient18)

debian/libmysqlclient18.lintian-overrides still refers to version
18.1. Fix the version number in line 3 and remove the last two, as
they aren't needed anymore.

> W: mysql-testsuite-5.6: unusual-interpreter  
> usr/lib/mysql-testsuite/std_data/dtrace.d #!/usr/sbin/dtrace
> E: mysql-testsuite-5.6: python-script-but-no-python-dep  
> usr/lib/mysql-testsuite/suite/opt_trace/validate_json.py

I don't know how to fix this. I googled it, and it seems you're
supposed to use dh_python2, but that's about as far as I got. I've
never packaged python stuff.

> W: mysql-testsuite-5.6: script-not-executable  
> usr/lib/mysql-testsuite/t/long_tmpdir-master.sh
> W: mysql-testsuite-5.6: script-not-executable  
> usr/lib/mysql-testsuite/t/lowercase_mixed_tmpdir-master.sh
> W: mysql-testsuite-5.6: script-not-executable  
> usr/lib/mysql-testsuite/t/lowercase_mixed_tmpdir_innodb-master.sh

These are correctly set as +x in the upstream package. File
permissions in r/ and t/ are fixed in 5.6.20, so the chmod in
debian/rules isn't needed anymore.

I also removed som unnecessary chmods in debian/rules. The fix for
upstream bug #68517 is in 5.6.20.

> E: mysql-server-5.6: duplicate-updaterc.d-calls-in-postrm mysql

Should lines 69-73 of debian/mysql-server-5.6.postrm be deleted?
dh_installinit will add similar code later in the script that will be
run on purge. I've removed them in my patch.

> W: mysql-server-5.6: manpage-has-errors-from-man  
> usr/share/man/man1/mysqlbinlog.1.gz 1846: warning [p 10, 5.5i, div  
> `3tbd3,2', 0.8i]: can't break line
> W: mysql-client-5.6: manpage-has-errors-from-man  
> usr/share/man/man1/mysqladmin.1.gz 37: warning [p 1, 1.5i]: can't break  
> line
> W: mysql-client-5.6: manpage-has-errors-from-man  
> usr/share/man/man1/mysqldump.1.gz 1310: warning [p 8, 6.7i, div  
> `3tbd3,1', 0.3i]: can't break line

There's an upstream bug report for these:
http://bugs.mysql.com/bug.php?id=73022

Regards,

Norvald H. Ryeng
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mysql-5.6.20-lintianfixes.patch
Type: application/octet-stream
Size: 5057 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-mysql-maint/attachments/20140901/f5f8c899/attachment.obj>