[debian-mysql] mysql-5.6.26 build fails "exception handling disabled"

[Lars Tangvald]

The necessary flags should be provided by upstream's cmake config, so 
I'd simply remove the two lines overriding CMAKE_C_FLAGS and 
CMAKE_CXX_FLAGS from debian/rules.
It's difficult to maintain, hard to find issues (no-exceptions should 
have been removed 4 years ago, BIG_JOINS no longer exists, etc), and 
using a different build setup than upstream could also bring unforeseen 
issues.

--
Lars

On 09/30/2015 11:18 AM, Bjoern Boschman wrote:
> Hi Lars,
>
> so currently there are:
> -O3 -DBIG_JOINS=1 -felide-constructors -fno-exceptions -fpermissive 
> -fno-rtti -fPIC -fno-strict-aliasing
> I'd drop -fno-exceptions and -fno-rtti. which other would you suggest 
> to drop?
>
> Cheers
> B
>
> On Tue, Sep 29, 2015 at 10:40 AM Lars Tangvald 
> <lars.tangvald at oracle.com <mailto:lars.tangvald at oracle.com>> wrote:
>
>     Upstream, this was actually changed in 5.6.4, for MySQL worklog #5825:
>     http://dev.mysql.com/worklog/task/?id=5825
>     Accompanying commit:
>     https://github.com/mysql/mysql-server/commit/a5ee7278a16a6a5e6e90c56c13fdda7f6f30ebad
>
>     So the flags should probably just be removed. From what I can see
>     this actually applies to the other flags as well. They all seem to
>     be outdated.
>
>     The commit causing the compile error:
>     https://github.com/mysql/mysql-server/commit/0ff896b063916e46d3ab175594f5507756c08adb
>
>
>     --
>     Lars
>
>
>     On 09/29/2015 08:20 AM, Lars Tangvald wrote:
>>     Also note that both no-exceptions and no-rtti will cause compile
>>     errors with MySQL 5.7.8. I don't see much reason to keep either
>>     flag, as I assume they're just holdovers from optimizations of
>>     old versions?
>>
>>     --
>>     Lars
>>
>>
>>     On 09/28/2015 06:25 PM, Bjoern Boschman wrote:
>>>     Hi,
>>>
>>>     while compiling 5.6.26 I got the following error:
>>>
>>>     cd
>>>     /home/jesusch/git/mysql/mysql-5.6/builddir/plugin/password_validation
>>>     && /usr/bin/x86_64-linux-gnu-g++ -DHAVE_CONFIG_H
>>>     -DMYSQL_DYNAMIC_PLUGIN -D_FORTIFY_SOURCE=2
>>>     -Dvalidate_password_EXPORTS -O3 -DBIG_JOINS=1
>>>     -felide-constructors -fno-exceptions -fpermissive -fno-rtti
>>>      -fno-strict-aliasing  -Wall -Wextra -Wformat-security -Wvla
>>>     -Woverloaded-virtual -Wno-unused-parameter -O3 -g
>>>     -fabi-version=2 -fno-omit-frame-pointer -fno-strict-aliasing
>>>     -DDBUG_OFF -fPIC
>>>     -I/home/jesusch/git/mysql/mysql-5.6/builddir/include
>>>     -I/home/jesusch/git/mysql/mysql-5.6/include
>>>     -I/home/jesusch/git/mysql/mysql-5.6/sql
>>>     -I/home/jesusch/git/mysql/mysql-5.6/regex
>>>     -I/home/jesusch/git/mysql/mysql-5.6/extra/yassl/include
>>>     -I/home/jesusch/git/mysql/mysql-5.6/extra/yassl/taocrypt/include
>>>        -o CMakeFiles/validate_password.dir/validate_password.cc.o -c
>>>     /home/jesusch/git/mysql/mysql-5.6/plugin/passwor
>>>     d_validation/validate_password.cc
>>>     /home/jesusch/git/mysql/mysql-5.6/plugin/password_validation/validate_password.cc:
>>>     In function ‘void read_dictionary_file()’:
>>>     /home/jesusch/git/mysql/mysql-5.6/plugin/password_validation/validate_password.cc:183:10:
>>>     error: exception handling disabled, use -fexceptions to enable
>>>
>>>     Is there any reason why we have CXXFLAGS="... -fno-exceptions"?
>>>
>>>     Cheers
>>>     B
>>>
>>>
>>>     _______________________________________________
>>>     pkg-mysql-maint mailing list
>>>     pkg-mysql-maint at lists.alioth.debian.org
>>>     <mailto:pkg-mysql-maint at lists.alioth.debian.org>
>>>     http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-mysql-maint
>>
>>
>>
>>     _______________________________________________
>>     pkg-mysql-maint mailing list
>>     pkg-mysql-maint at lists.alioth.debian.org
>>     <mailto:pkg-mysql-maint at lists.alioth.debian.org>
>>     http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-mysql-maint
>
>     _______________________________________________
>     pkg-mysql-maint mailing list
>     pkg-mysql-maint at lists.alioth.debian.org
>     <mailto:pkg-mysql-maint at lists.alioth.debian.org>
>     http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-mysql-maint
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.alioth.debian.org/pipermail/pkg-mysql-maint/attachments/20150930/605e7cd3/attachment.html>