[debian-mysql] Bug#852776: Bug#852776: Bug#852776: mariadb-server-10.1: init script doesn't specify it should be started prior to apache2 etc

[Julian Gilbey]

On Fri, Jan 27, 2017 at 01:45:58PM +0000, Robie Basak wrote:
> Hi Otto and Julian,
> 
> On Fri, Jan 27, 2017 at 02:46:39PM +0200, Otto Kekäläinen wrote:
> > As MariaDB and MySQL and functionally equvalent, we try to keep their
> > packaging identical as much as possible. If the packages divert, then
> > the amount of testing/maintenance increases.
> 
> From a src:mysql-5.7 perspective, I'd be quite happy for the same change
> to be pushed. As long as whoever pushes it also deals with any related
> subequent bugs.
> 
> We don't really have anyone specifically looking after the init.d
> scripts at the moment I don't think. Since the systemd stuff is default
> now, our focus is on that. But init.d contributions are welcome so long
> as contributors take responsibility for their changes.
> 
> Go ahead and push to mysql.git/mysql-5.7/debian/master if you wish.

Hi Robie,

I don't have the privileges to be able to do so.  The change I would
suggest (and probably after stretch release - it's far from critical
and I wouldn't want to break things at this stage in the release
cycle, and bearing in mind that you don't want to have different logic
in the two packages' rules files), is in debian/rules to replace:

# Start mysql in runlevel 19 before 20 where apache, proftpd etc gets
# started which might depend on a running database server.
override_dh_installinit-arch:
        dh_installinit --name=mysql -- defaults 19 21
        dh_systemd_start --restart-after-upgrade

with the simpler:

override_dh_systemd_start-arch:
        dh_systemd_start --restart-after-upgrade

But I haven't yet had the chance to test this.

Note that this is the default behaviour in debhelper compat level 10,
anyway, so it may be worth considering migrating to that in stretch+1,
and then this clause can be removed entirely.

Best wishes,

   Julian