[debian-mysql] Bug#861166: mariadb-10.1: FTBFS on hurd-i386 (uses PATH_MAX)

[Ondřej Surý]

Hi Svante,

thanks for the patch.

I briefly reviewed the patch and it seems like it is touching places
outside pure GNU Hurd space. Would you be willing to prenegotiate the
inclusion of this with the release team?

Cheers,
-- 
Ondřej Surý <ondrej at sury.org>
Knot DNS (https://www.knot-dns.cz/) – a high-performance DNS server
Knot Resolver (https://www.knot-resolver.cz/) – secure, privacy-aware,
fast DNS(SEC) resolver
Vše pro chleba (https://vseprochleba.cz) – Mouky ze mlýna a potřeby pro
pečení chleba všeho druhu

On Mon, May 8, 2017, at 15:34, Svante Signell wrote:
> tags 861166 patch
> found 861166 10.1.23-3
> thanks
> 
> On Tue, 2017-04-25 at 11:42 +0200, Svante Signell wrote:
> > On Tue, 2017-04-25 at 11:32 +0200, Mattia Rizzolo wrote:
> > > Source: mariadb-10.1
> > > Severity: important
> > > User: debian-hurd at lists.debian.org
> > > Usertags: hurd
> ...
> > > On a more general note: this package is very important due to being a
> > > dependecy of things like Qt, gdal and several others, so it's appreciate
> > > if it stays buildable on all architectures.
> > 
> > I can take a look if nobody else beats me to it.
> 
> Attached are patches to make mariadb-10.1 to build on GNU/Hurd.
> Unfortunately
> there are still some warnings to fix and the testsuite fails, and has
> been
> removed with debian/rules patch. Attached is also an updated symbols
> file, the
> link given in debian/ points to a file having three symbols not in the
> Hurd
> version.
> 
> The patched package has also been successfully built on GNU/Linux amd64
> with
> pbuilder. It does not build in my host environment, 10 tests do time-out,
> any
> ideas?
> 
> cmake.patch defines the system name GNU, tries to disable dtrace (which
> is Linux
> only from systemtap-sdt-dev) and add a check for HAVE_SYS_POLL_H, see
> path_max.patch. Unfortunately disabling dtrace did not work, I had to
> uninstall 
> systemtap-sdt-dev, I wonder why?
> 
> path_max.patch defines GNU_SOURCE if not already defined, avoids a
> FreeBSD-
> specific definition of O_PATH, and fixes PATH_MAX issues in files
> /mysys/mysys_priv.h, sql/wsrep_binlog.cc and
> extra/mariabackup/backup_copy.cc.
> The POLL stuff in storage/mroonga/vendor/groonga/lib/grn_com.h and
> storage/mroonga/vendor/groonga/lib/com.c fixes the USE_POLL case. That
> case is
> not properly handled in the upstream code. GNU/Hurd could of course use
> USE_SELECT, but since the OS is detected as using POLL, that choice is
> fixed
> too.
> 
> There are probably other fixes needed too, feedback welcomed.
> 
> Thanks!  
> 
> Email had 4 attachments:
> + cmake.patch
>   2k (text/x-patch)
> + debian_rules.patch
>   1k (text/x-patch)
> + libmariadbclient18.symbols.hurd-i386
>   50k (text/plain)
> + path_max.patch
>   13k (text/x-patch)