[debian-mysql] Please update/review your patches for MariaDB 10.3 in Debian

[Vicențiu Ciorbaru]

I've attached a patch that should fix the gitlab-ci MEMORY engine test 
failure too.


On 20/12/2018 10:58, Vicențiu Ciorbaru wrote:
> Hi Otto!
>
> armhf_mroonga_storage_fail.patch can be removed. It was applied upstream.
>
> I have tried submitting a merge request for an updated c11_atomics 
> patch, however I think I require an invitation to the team to be able 
> to do that from the GitLab interface. As time is short, I have 
> attached the commit instead.
>
> I expect it will be merged to upstream for the next release too.
> Note that I did not spend time testing this particular fix on a mips 
> machine as I do not have one handy and emulating it still takes a day 
> and half to compile. I believe that if you push to debian 
> infrastructure it will be faster.
>
> Will be looking into the other failures now.
>
> Vicențiu
>
> On Tue, 18 Dec 2018 at 18:31 Otto Kekäläinen <otto at debian.org 
> <mailto:otto at debian.org>> wrote:
>
>     Hello Vicențiu!
>
>     You have contributed to some of the patches at
>     https://salsa.debian.org/mariadb-team/mariadb-10.3/tree/master/debian/patches
>
>     Some of them don't apply anymore and I have disabled them:
>     - armhf_mroonga_storage_fail.patch
>     - c11_atomics.patch
>
>     Could you please refresh them or let me know if you don't have any use
>     for them anymore, or if something new in upstream has made them
>     obsolete?
>
>     They are now disabled and if nobody contributes to fix them for the
>     10.3 era I will probably scrap them at some point.
>
>     I prefer contributions as merge requests on Debian's new Gitlab
>     instance called Salsa:
>     https://wiki.debian.org/Teams/MySQL/patches
>
>     Maintaining MariaDB in Debian is a very big task and I appreciate all
>     help I get that decreases my workload. Thanks for your previous
>     contributions and hopefully you can continue contributing!
>
>
>     -- 
>     Otto Kekäläinen
>     Follow me on https://twitter.com/ottokekalainen
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/pkg-mysql-maint/attachments/20181220/581a9a44/attachment.html>
-------------- next part --------------
commit bd709c19a37f20364af63a7afaad8a26cd819214
Author: Vicențiu Ciorbaru <vicentiu at mariadb.org>
Date:   Thu Dec 20 11:14:06 2018 +0200

    Fix MEMORY storage engine test
    
    The current testcase was inserting the same value in a SERIAL column,
    which is an ALIAS for BIGINT UNSIGNED NOT NULL AUTO_INCREMENT UNIQUE.
    Duplicate values are not allowed.

diff --git a/debian/gitlab-ci.yml b/debian/gitlab-ci.yml
index d1ceddf86..63df6b7fc 100644
--- a/debian/gitlab-ci.yml
+++ b/debian/gitlab-ci.yml
@@ -191,7 +191,7 @@ test features:
     - mariadb -e "SELECT * FROM db.t_innodb; INSERT INTO db.t_innodb VALUES (3,'"'"'foo'"'"'),(4,'"'"'bar'"'"')"
     - mariadb -e "SELECT * FROM db.t_myisam; INSERT INTO db.t_myisam VALUES (3,'"'"'foo'"'"'),(4,'"'"'bar'"'"')"
     - mariadb -e "SELECT * FROM db.t_aria; INSERT INTO db.t_aria VALUES (3,'"'"'foo'"'"'),(4,'"'"'bar'"'"')"
-    - mariadb -e "SELECT * FROM db.t_memory; INSERT INTO db.t_memory VALUES (1,'"'"'foo'"'"'),(2,'"'"'bar'"'"')"
+    - mariadb -e "SELECT * FROM db.t_memory; INSERT INTO db.t_memory VALUES (3,'"'"'foo'"'"'),(4,'"'"'bar'"'"')"
     - mariadb -e "SELECT COUNT(*) FROM db.v_merge"
     - mariadb -e "SELECT COUNT(*) FROM db.v_temptable"
     - mariadb -e "CALL db.p()"