[debian-mysql] Bug#971005: Bug#971005: mariadb-10.5: unregistered vendor copy of readline

[Helmut Grohne]

Control: severity -1 wishlist
Control: retitle -1 make it harder to accidentally use the bundled readline

Hi Otto,

On Mon, Sep 28, 2020 at 11:02:03AM +0300, Otto Kekäläinen wrote:
> There is indeed in the sources extra/readline/.
> 
> Looking at upstream commit logs it has been there at least since 2014
> (and traces of the same are in Oracle mysql sources too). This is not
> something new that has been introduced in 10.5, but rather very old
> legacy.
> 
> The cmake/readline.cmake file should ensure the system libedit is
> always used in Debian.

I stand corrected! I only managed to get into this situation by failing
to provide all relevant build-depends. My fault. It really does build
using the system libedit by default as can be seen from the buildd logs.

The only thing that you might want to consider changing is making it
harder to accidentally use the bundled readline.

> I will experiment by removing the whole extra/readline/ from the
> Debian sources and then file an issue about it upstream.

I think the situation is fine from an upstream pov. It really does
prefer libedit when libedit is available.

I've attemped adding a "rm -Rf extra/readline" to override_dh_auto_clean
and that seems to just work. When you build a source package after
performing a binary package build you get a pile of warnings abouts
deleted files being ignored as a difference, but I'm used to that from
other packages already. Does that work for you?

Given the above, I see basically two options for moving forward:
 a) Close the bug with no action (as indeed the embedded copy is
    unused).
 b) Delete it during clean.

I'm happy with either choice.

Helmut