[debian-mysql] Bug#988349: mariadb-10.5: FTBFS on sh4: test suite fails to start

[Otto Kekäläinen]

Source: mariadb-10.5
Version: 1:10.5.9-1
Tags: confirmed, help, ftbfs
Severity: normal
Justification: source does build, but tests don't run and binaries are
unvalidated
User: debian-sh4 at lists.debian.org
Usertags: sh4

Related: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=972057

I noticed in the sh4 build log that the test suite does not start
after the build:

*********************
Full log: https://buildd.debian.org/status/fetch.php?pkg=mariadb-10.5&arch=sh4&ver=1%3A10.5.9-1&stamp=1617143952&raw=0:
*********************
make[1]: Entering directory '/<<PKGBUILDDIR>>'
RULES.override_dh_auto_test
dh_testdir
# Skip unstable tests if such are defined for arch
cp mysql-test/unstable-tests debian/mysql-test-unstable-tests.orig
[ ! -f debian/unstable-tests.sh4 ] || cat debian/unstable-tests.sh4 >>
mysql-test/unstable-tests
# Run testsuite
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
   create-stamp debian/debhelper-build-stamp
   dh_testroot -a -O--fail-missing
   dh_prep -a -O--fail-missing
rm -f -- debian/libmariadb-dev.substvars [..]
   debian/rules override_dh_auto_install
make[1]: Entering directory '/<<PKGBUILDDIR>>'
RULES.override_dh_auto_install
*********************

For some unknown reason mtr does not start at all. Thus we don't know
if the sh4 build actually succeeded or not.

In a normal build it should look like:

*********************
Full log at: https://buildd.debian.org/status/fetch.php?pkg=mariadb-10.5&arch=x32&ver=1%3A10.5.9-1&stamp=1614082043&raw=0
*********************
RULES.override_dh_auto_test
dh_testdir
# Skip unstable tests if such are defined for arch
cp mysql-test/unstable-tests debian/mysql-test-unstable-tests.orig
[ ! -f debian/unstable-tests.x32 ] || cat debian/unstable-tests.x32 >>
mysql-test/unstable-tests
# Run testsuite
# Don't use --mem here as official Debian builders and most Docker
systems don't have a large mem device available and
# would fail with errors on lack of disk space.
cd builddir/mysql-test && \
./mtr --force --testcase-timeout=120 --suite-timeout=540 --retry=3 \
[...]
*********************


This is how the debian/rules looks like:

 override_dh_auto_test:
     @echo "RULES.$@"
     dh_testdir
     # Skip unstable tests if such are defined for arch
     cp mysql-test/unstable-tests debian/mysql-test-unstable-tests.orig
     [ ! -f debian/unstable-tests.$(DEB_HOST_ARCH) ] || cat
debian/unstable-tests.$(DEB_HOST_ARCH) >> mysql-test/unstable-tests
     # Run testsuite
 ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS)))
     # Don't use --mem here as official Debian builders and most
Docker systems don't have a large mem device available and
     # would fail with errors on lack of disk space.
     cd $(BUILDDIR)/mysql-test && \
     ./mtr --force --testcase-timeout=120 --suite-timeout=540 --retry=3 \
           --parallel=$(NUMJOBS) --skip-rpl --suite=main \
           --skip-test-list=unstable-tests
 endif


It is if as the line ` ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS)))`
always evaluated false..?