[pkg-nagios-changes] [Git][nagios-team/nagvis][upstream] New upstream version 1.10.3

[Bas Couwenberg (@sebastic)]

Bas Couwenberg pushed to branch upstream at Debian Nagios Maintainer Group / nagvis


Commits:
cffdff2c by Bas Couwenberg at 2026-05-07T15:38:29+02:00
New upstream version 1.10.3
- - - - -


3 changed files:

- ChangeLog
- share/server/core/classes/ViewMapAddModify.php
- share/server/core/defines/global.php


Changes:

=====================================
ChangeLog
=====================================
@@ -1,3 +1,6 @@
+1.10.3
+  * FIX: Saving map elements incorrectly applied all attributes after the unchecked-checkbox submission fix
+
 1.10.2
   * FIX: JS crash on maps with image gadgets caused by block-scoped const introduced in var-to-let refactor
 


=====================================
share/server/core/classes/ViewMapAddModify.php
=====================================
@@ -79,7 +79,7 @@ class ViewMapAddModify
 
             if (
                 (isset($attrDefs[$attr]['must']) && $attrDefs[$attr]['must'] == '1')
-                || !has_var('toggle_' . $attr)
+                || !has_var('_has_toggle_' . $attr)
                 || get_checkbox('toggle_' . $attr)
             ) {
                 if (isset($attrDefs[$attr]['array']) && $attrDefs[$attr]['array']) {
@@ -462,6 +462,12 @@ class ViewMapAddModify
         // Add a checkbox to toggle the usage of an attribute. But only add it for
         // non-must attributes.
         if (!$prop['must'] && $fieldType != 'readonly') {
+            // Sentinel hidden field so the server can detect that this toggle exists
+            // in the form regardless of whether the checkbox is checked or not.
+            // Unchecked checkboxes are not submitted by the browser (or by getFormParams),
+            // so has_var('toggle_X') alone cannot distinguish "toggle rendered but unchecked"
+            // from "no toggle rendered at all".
+            hidden('_has_toggle_' . $propname, '1');
             checkbox(
                 'toggle_' . $propname,
                 $isInherited === false,


=====================================
share/server/core/defines/global.php
=====================================
@@ -24,7 +24,7 @@
  *****************************************************************************/
 
 // NagVis Version
-const CONST_VERSION = '1.10.2';
+const CONST_VERSION = '1.10.3';
 
 // Set PHP error handling to standard level
 // Different levels for php versions below 5.1 because PHP 5.1 reports



View it on GitLab: https://salsa.debian.org/nagios-team/nagvis/-/commit/cffdff2c411224f3887a0cdbed937f89e5c8ef96

-- 
View it on GitLab: https://salsa.debian.org/nagios-team/nagvis/-/commit/cffdff2c411224f3887a0cdbed937f89e5c8ef96
You're receiving this email because of your account on salsa.debian.org. Manage all notifications: https://salsa.debian.org/-/profile/notifications | Help: https://salsa.debian.org/help


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/pkg-nagios-changes/attachments/20260507/9ff7bedc/attachment-0001.htm>