[Pkg-nagios-devel] Bug#316534: marked as done (nagios-plugins: check_ups gives incorrect perf output with -T)

Debian Bug Tracking System owner at bugs.debian.org
Fri Oct 7 21:18:24 UTC 2005

Your message dated Fri, 07 Oct 2005 14:02:04 -0700
with message-id <E1ENzLw-0004On-00 at spohr.debian.org>
and subject line Bug#316534: fixed in nagios-plugins 1.4.2-2
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

Received: (at submit) by bugs.debian.org; 1 Jul 2005 16:02:16 +0000
>From chris at atlee.ca Fri Jul 01 09:02:16 2005
Return-path: <chris at atlee.ca>
Received: from tor149-99-58-193.dedicated.sprintdsl.ca (mail.sidefx.com) [] 
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1DoNy4-000402-00; Fri, 01 Jul 2005 09:02:16 -0700
Received: from antigua.sidefx.com (antigua.sidefx.com[])
	by mail.sidefx.com (Smail- 2000-Feb-17 #5; 2004-May-20)
	(4638 bytes) via sendmail with /P:esmtp/R:inet_hosts/T:smtp
	id <m1DoNy2-004ot8C at mail.sidefx.com>
	(sender <chris at atlee.ca>)
	for <submit at bugs.debian.org>; Fri, 1 Jul 2005 12:02:14 -0400 (EDT)
Received: by antigua.sidefx.com (Postfix, from userid 471)
	id CEF0B8F40C8; Fri,  1 Jul 2005 12:02:13 -0400 (EDT)
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
From: Chris AtLee <chris at atlee.ca>
To: Debian Bug Tracking System <submit at bugs.debian.org>
Subject: nagios-plugins: check_ups gives incorrect perf output with -T
X-Mailer: reportbug 3.15
Date: Fri, 01 Jul 2005 12:02:13 -0400
Message-Id: <20050701160213.CEF0B8F40C8 at antigua.sidefx.com>
Delivered-To: submit at bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE 
	autolearn=no version=2.60-bugs.debian.org_2005_01_02

Package: nagios-plugins
Version: 1.4-6
Severity: normal
Tags: patch

When specifying -T to check_ups to get the UPS temperature in Celsius, I
get the following output:
UPS OK - Status=Online Utility=115.9V Batt=100.0% Load=78.6% Temp=27.4C|voltage=115900mV;;;0 battery=100%;;;0;100 load=78%;;;0;100 temp=27degF;;;0

The temperature is correct, but in the perf data section, the units are

A simple patch to check_ups.c fixes this:

--- check_ups.c 2004-12-25 18:17:44.000000000 -0500
+++ check_ups.c.new     2005-07-01 11:57:39.211673645 -0400
@@ -280,11 +280,14 @@
                return STATE_CRITICAL;
        else {
                supported_options |= UPS_TEMP;
+               char * tempUnits;
                if (temp_output_c) {
+                 tempUnits = "degC";
                  ups_temperature = atof (temp_buffer);
                  asprintf (&message, "%sTemp=%3.1fC", message, ups_temperature);
                else {
+                 tempUnits = "degF";
                  ups_temperature = (atof (temp_buffer) * 1.8) + 32;
                  asprintf (&message, "%sTemp=%3.1fF", message, ups_temperature);
@@ -297,13 +300,13 @@
                                result = max_state (result, STATE_WARNING);
                        asprintf (&data, "%s %s", data,
-                                 perfdata ("temp", (long)ups_temperature, "degF",
+                                 perfdata ("temp", (long)ups_temperature, tempUnits,
                                            check_warn, (long)(1000*warning_value),
                                            check_crit, (long)(1000*critical_value),
                                            TRUE, 0, FALSE, 0));
                } else {
                        asprintf (&data, "%s %s", data,
-                                 perfdata ("temp", (long)ups_temperature, "degF",
+                                 perfdata ("temp", (long)ups_temperature, tempUnits,
                                            FALSE, 0, FALSE, 0, TRUE, 0, FALSE, 0));

-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'stable')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.10-1-686
Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8)

Versions of packages nagios-plugins depends on:
ii  bind9-host [host]      1:9.3.1-2         Version of 'host' bundled with BIN
ii  dnsutils               1:9.3.1-2         Clients provided with BIND
ii  fping                  2.4b2-to-ipv6-11  sends ICMP ECHO_REQUEST packets to
ii  iputils-ping           3:20020927-2      Tools to test the reachability of 
ii  libc6                  2.3.2.ds1-22      GNU C Library: Shared libraries an
ii  libldap2               2.1.30-10         OpenLDAP libraries
ii  libmysqlclient12       4.0.24-10         mysql database client library
ii  libnet-snmp-perl       5.0.1-1           Script SNMP connections
ii  libpq3                 1:7.4.8-10        PostgreSQL C client library
ii  libssl0.9.7            0.9.7g-1          SSL shared libraries
ii  ntp                    1:4.2.0a+stable-8 Network Time Protocol: network uti
ii  ntp-simple             1:4.2.0a+stable-8 Network Time Protocol: daemon for 
ii  ntpdate                1:4.2.0a+stable-8 The ntpdate client for setting sys
ii  procps                 1:3.2.5-1         /proc file system utilities
ii  qstat                  2.8-1             Command-line tool for querying qua
ii  radiusclient1          0.3.2-8           /bin/login replacement which uses 
ii  smbclient              3.0.14a-5         a LanManager-like simple client fo
ii  snmp                   5.1.2-6.1         NET SNMP (Simple Network Managemen

Versions of packages nagios-plugins recommends:
pn  nagios-text | nagios          <none>     (no description available)

-- no debconf information

Received: (at 316534-close) by bugs.debian.org; 7 Oct 2005 21:08:41 +0000
>From katie at spohr.debian.org Fri Oct 07 14:08:40 2005
Return-path: <katie at spohr.debian.org>
Received: from katie by spohr.debian.org with local (Exim 3.36 1 (Debian))
	id 1ENzLw-0004On-00; Fri, 07 Oct 2005 14:02:04 -0700
From: sean finney <seanius at debian.org>
To: 316534-close at bugs.debian.org
X-Katie: $Revision: 1.56 $
Subject: Bug#316534: fixed in nagios-plugins 1.4.2-2
Message-Id: <E1ENzLw-0004On-00 at spohr.debian.org>
Sender: Archive Administrator <katie at spohr.debian.org>
Date: Fri, 07 Oct 2005 14:02:04 -0700
Delivered-To: 316534-close at bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER 
	autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-CrossAssassin-Score: 5

Source: nagios-plugins
Source-Version: 1.4.2-2

We believe that the bug you reported is fixed in the latest version of
nagios-plugins, which is due to be installed in the Debian FTP archive:

  to pool/main/n/nagios-plugins/nagios-plugins_1.4.2-2.diff.gz
  to pool/main/n/nagios-plugins/nagios-plugins_1.4.2-2.dsc
  to pool/main/n/nagios-plugins/nagios-plugins_1.4.2-2_i386.deb

A summary of the changes between this version and the previous one is

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 316534 at bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
sean finney <seanius at debian.org> (supplier of updated nagios-plugins package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster at debian.org)

Hash: SHA1

Format: 1.7
Date: Fri, 07 Oct 2005 22:19:09 +0200
Source: nagios-plugins
Binary: nagios-plugins
Architecture: source i386
Version: 1.4.2-2
Distribution: unstable
Urgency: low
Maintainer: seanius at debian.org
Changed-By: sean finney <seanius at debian.org>
 nagios-plugins - Plugins for the nagios network monitoring and management system
Closes: 278817 306244 308458 312228 316534 316882 327212 332667
 nagios-plugins (1.4.2-2) unstable; urgency=low
   * Sean Finney:
     - ack, the perl plugins broke on the last upload, because "use lib"
       wasn't being properly substituted in.  fixed. (closes: #332667).
     - include upstream fix for check_ups temperature perfdata.  thanks
       to Chris AtLee for originally reporting this (closes: #316534).
     - stop mucking around with config.sub/config.guess in debian/rules.
     - last update in the changelog was missing a colon on the following:
       (closes: #312228, #306244, #308458, #327212, #316882).
     - have check_mysql read in defaults from my.cnf (closes: #278817).
 aaa7a8e305d1ea300d27fd4350379314 959 net extra nagios-plugins_1.4.2-2.dsc
 cabe99cfabace7af16464a00c14a02f3 28967 net extra nagios-plugins_1.4.2-2.diff.gz
 54bde448e6b541bf63a52676aa138b1d 354576 net extra nagios-plugins_1.4.2-2_i386.deb

Version: GnuPG v1.4.2 (GNU/Linux)


More information about the Pkg-nagios-devel mailing list