[Pkg-nagios-devel] Bug#268044: marked as done (check_ntp doesn't handle all ntpq output gracefully)

Debian Bug Tracking System owner at bugs.debian.org
Sun Oct 9 15:18:22 UTC 2005


Your message dated Sun, 9 Oct 2005 11:06:35 -0400
with message-id <20051009150635.GA21666 at seanius.net>
and subject line fixed in latest version, i'm pretty sure
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--------------------------------------
Received: (at submit) by bugs.debian.org; 25 Aug 2004 18:25:18 +0000
>From jeroen at wolffelaar.nl Wed Aug 25 11:25:18 2004
Return-path: <jeroen at wolffelaar.nl>
Received: from 233pc233.sshunet.nl (mordor.wolffelaar.nl) [131.211.233.233] (mail)
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1C02SU-0007VZ-00; Wed, 25 Aug 2004 11:25:18 -0700
Received: from jeroen by mordor.wolffelaar.nl with local (Exim 3.36 #1 (Debian))
	id 1C02SS-0000pX-00
	for <submit at bugs.debian.org>; Wed, 25 Aug 2004 20:25:16 +0200
Date: Wed, 25 Aug 2004 20:25:16 +0200
From: Jeroen van Wolffelaar <jeroen at wolffelaar.nl>
To: Debian Bug Tracking System <submit at bugs.debian.org>
Subject: check_ntp doesn't handle all ntpq output gracefully
Message-ID: <20040825182516.GA2675 at wolffelaar.nl>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
X-Reportbug-Version: 2.63
User-Agent: Mutt/1.5.6+20040722i
Delivered-To: submit at bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE 
	autolearn=no version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level: 

Package: nagios-plugins
Version: 1.3.1.0-9
Severity: normal

mordor:/etc/nagios# ntpq -np square
     remote           refid      st t when poll reach   delay   offset  jitter
==============================================================================
+131.211.32.72   131.211.81.10    2 u  600 1024  377    0.344    0.523   1.230
*131.211.80.155  PPS(0)           2 u   83 1024  377    0.810    0.482   0.043
x131.211.22.28   131.211.22.26    4 u  905 1024  377    1.284  -118.59   0.127
-131.211.4.6     193.67.79.202    2 u   76 1024  377    0.291    1.346   0.224
+131.211.4.5     131.211.80.155   3 u  928 1024  377    0.238    0.678   0.008
mordor:/etc/nagios# /usr/lib/nagios/plugins/check_ntp -H square
Use of uninitialized value in concatenation (.) or string at /usr/lib/nagios/plugins/check_ntp line 308.
NTP UNKNOWN: Jitter  too high
mordor:/etc/nagios#

Apparantly, this beast of a regex:

/^(\*|o)([-0-9.\s]+)\s+([-0-9A-Za-z.]+)\s+([-0-9.]+)\s+([lumb]+)\s+([-0-9m.]+)\s+([-0-9.]+)\s+([-0-9.]+)\s+([-0-9.]+)\s+([-0-9.]+)\s+([-0-9.]+)/

fails to match, and $jitter will then continue undefined without any errorchecking.

--Jeroen

-- System Information:
Debian Release: 3.1
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: i386 (i686)
Kernel: Linux 2.6.3
Locale: LANG=nl_NL.UTF-8 at euro, LC_CTYPE=nl_NL.UTF-8 at euro

Versions of packages nagios-plugins depends on:
ii  bind9-host [host]    1:9.2.3+9.2.4-rc5-1 Version of 'host' bundled with BIN
ii  dnsutils             1:9.2.3+9.2.4-rc5-1 Clients provided with BIND
ii  fping                2.4b2-to-ipv6-8     sends ICMP ECHO_REQUEST packets to
ii  libc6                2.3.2.ds1-13        GNU C Library: Shared libraries an
ii  libldap2             2.1.30-2            OpenLDAP libraries
ii  libmysqlclient10     3.23.56-2           LGPL-licensed client library for M
ii  libnet-snmp-perl     4.0.3-1             Script SNMP connections
ii  libpq3               7.4.3-3             Shared library libpq.so.3 for Post
ii  libssl0.9.7          0.9.7d-4            SSL shared libraries
ii  netkit-ping [ping]   0.10-9              The ping utility from netkit
ii  ntp                  1:4.2.0a-11         Network Time Protocol: network uti
ii  ntp-simple           1:4.2.0a-11         Network Time Protocol: daemon for 
ii  ntpdate              1:4.2.0a-11         The ntpdate client for setting sys
ii  procps               1:3.2.1-2           The /proc file system utilities
ii  qstat                2.5c-3              Command-line tool for querying qua
ii  radiusclient1        0.3.2-6             /bin/login replacement which uses 
ii  smbclient            3.0.5-1             a LanManager-like simple client fo
ii  snmp                 5.1.1-2             NET SNMP (Simple Network Managemen

-- no debconf information

-- 
Jeroen van Wolffelaar
jeroen at wolffelaar.nl
http://jeroen.A-Eskwadraat.nl

---------------------------------------
Received: (at 268044-close) by bugs.debian.org; 9 Oct 2005 15:07:09 +0000
>From seanius at seanius.net Sun Oct 09 08:07:09 2005
Return-path: <seanius at seanius.net>
Received: from dsl092-235-113.phl1.dsl.speakeasy.net (sativa.seanius.net) [66.92.235.113] 
	by spohr.debian.org with esmtp (Exim 3.36 1 (Debian))
	id 1EOclY-0001W3-00; Sun, 09 Oct 2005 08:07:09 -0700
Received: by sativa.seanius.net (Postfix, from userid 1000)
	id 663F215834; Sun,  9 Oct 2005 11:06:35 -0400 (EDT)
Date: Sun, 9 Oct 2005 11:06:35 -0400
From: sean finney <seanius at debian.org>
To: 268044-close at bugs.debian.org, 318664-close at bugs.debian.org
Subject: fixed in latest version, i'm pretty sure
Message-ID: <20051009150635.GA21666 at seanius.net>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="y0ulUmNC+osPPQO6"
Content-Disposition: inline
User-Agent: Mutt/1.5.5.1+cvs20040105i
Delivered-To: 268044-close at bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level: 
X-Spam-Status: No, hits=-3.0 required=4.0 tests=BAYES_00 autolearn=no 
	version=2.60-bugs.debian.org_2005_01_02


--y0ulUmNC+osPPQO6
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

hi jeroen, steve,

numerous fixes to check_ntp have been included since 1.3.x, so i'm going
to go out on a limb and say that the check_ntp problems are resolved.
if they are in fact not, we can reopen the bug reports :)


	sean

--=20

--y0ulUmNC+osPPQO6
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFDSTH7ynjLPm522B0RApJXAJ4hwFNoL5fCJIY6HHZ5jRHFL1lOPACfZTD0
6YNyDXM+fP4i0ODU/qlEHvI=
=VsH3
-----END PGP SIGNATURE-----

--y0ulUmNC+osPPQO6--



More information about the Pkg-nagios-devel mailing list