[Pkg-nagios-devel] Bug#310780: marked as done (nagios-plugins: some
patches)
Debian Bug Tracking System
owner at bugs.debian.org
Mon Oct 31 22:48:14 UTC 2005
Your message dated Mon, 31 Oct 2005 14:32:13 -0800
with message-id <E1EWiCL-0006no-00 at spohr.debian.org>
and subject line Bug#310780: fixed in nagios-plugins 1.4.2-5
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 25 May 2005 22:17:47 +0000
>From f.a.g.luteijn at knoware.nl Wed May 25 15:17:47 2005
Return-path: <f.a.g.luteijn at knoware.nl>
Received: from 29-10.bbned.dsl.internl.net (firewall.fluteijn.knoware.nl) [82.215.10.29]
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1Db4CA-0004IY-00; Wed, 25 May 2005 15:17:46 -0700
Received: from printserver.fluteijn.knoware.nl (printserver.fluteijn.knoware.nl [192.168.2.2])
by firewall.fluteijn.knoware.nl (8.12.3/8.12.3/Debian-7.1) with ESMTP id j4PMHhXJ009523
(version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=OK);
Thu, 26 May 2005 00:17:44 +0200
Received: from printserver.fluteijn.knoware.nl (smmsp at localhost [127.0.0.1])
by printserver.fluteijn.knoware.nl (8.12.3/8.12.3/Debian-7.1) with ESMTP id j4PMHgQ0012364
(version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=OK);
Thu, 26 May 2005 00:17:43 +0200
Received: (from root at localhost)
by printserver.fluteijn.knoware.nl (8.12.3/8.12.3/Debian-7.1) id j4PMHgIS012363;
Thu, 26 May 2005 00:17:42 +0200
Message-Id: <200505252217.j4PMHgIS012363 at printserver.fluteijn.knoware.nl>
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
From: "F.A.G. Luteijn" <f.a.g.luteijn at knoware.nl>
To: Debian Bug Tracking System <submit at bugs.debian.org>
Subject: nagios-plugins: some patches
X-Mailer: reportbug 2.63
Date: Thu, 26 May 2005 00:17:42 +0200
X-BadReturnPath: root at fluteijn.knoware.nl rewritten as f.a.g.luteijn at knoware.nl
using "From" header
Delivered-To: submit at bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE
autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level:
Package: nagios-plugins
Version: 1.4-3
Severity: wishlist
Tags: patch
I have added a configuration file for checking dhcp, but the plugin only runs as
root.
I also have made some changes to the plugin check_disk_smb and that
implemented in the file disk.cfg. In the plugin check_disk_smb I have
added the option "-a" for the address to check servers if they are on a
different network. Further, it is legal to have spaces in windows-hostnames,
so I implemented that too.
I have added the command check_https_auth, because I have to
authenticate to get the test-page.
I have corrected some pathes, because in Debian those coommands are in
/usr/bin in stead of /bin.
In the plugin check_mailq I have disabled the emptying the PATH-variable
to disable errormessages.
-- System Information:
Debian Release: 3.0
Architecture: i386 (i586)
Kernel: Linux 2.4.27
Locale: LANG=C, LC_CTYPE=C
Versions of packages nagios-plugins depends on:
ii bind9-host [host] 1:9.2.1-2.woody.2 Version of 'host' bundled with BIN
ii dnsutils 1:9.2.1-2.woody.2 Clients provided with BIND
ii fping 2.4b2-to-ipv6-4 Send ICMP ECHO_REQUEST packets to
ii iputils-ping [ping] 3:20020124-3 The ping utility from iputils
ii libc6 2.3.2.ds1-21 GNU C Library: Shared libraries an
ii libldap2 2.1.23-1 OpenLDAP libraries
ii libmysqlclient12 4.0.21-7 mysql database client library
ii libnet-snmp-perl 3.6-7 Script SNMP connections
ii libpq3 7.4.5-3 Shared library libpq.so.3 for Post
ii libssl0.9.7 0.9.7d-5 SSL shared libraries
ii ntp 1:4.1.0-8 Daemon and utilities for full NTP
ii ntp-simple 1:4.1.0-8 NTP v4 daemon for simple systems.
ii ntpdate 1:4.1.0-8 The ntpdate client for setting sys
ii procps 1:2.0.7-8.woody1 The /proc file system utilities.
ii qstat 2.4e-1 Command-line tool for querying qua
ii radiusclient1 0.3.1-12.1 /bin/login replacement which uses
ii smbclient 2.2.3a-15 A LanManager like simple client fo
ii snmp 4.2.3-2 NET SNMP (Simple Network Managemen
-- no debconf information
--- Cut here ---
diff -rcN /etc/nagios-plugins/config.orig/dhcp.cfg /etc/nagios-plugins/config/dhcp.cfg
*** /etc/nagios-plugins/config.orig/dhcp.cfg Thu Jan 1 01:00:00 1970
--- /etc/nagios-plugins/config/dhcp.cfg Mon May 9 18:47:26 2005
***************
*** 0 ****
--- 1,12 ----
+ # 'check_dhcp' command definition
+ define command{
+ command_name check_dhcp
+ command_line /usr/lib/nagios/plugins/check_dhcp -s $HOSTADDRESS$
+ }
+
+ # 'check_dhcp_interface' command definition
+ define command{
+ command_name check_dhcp_interface
+ command_line /usr/lib/nagios/plugins/check_dhcp -s $HOSTADDRESS$ -i $ARG1$
+ }
+
diff -rcN /etc/nagios-plugins/config.orig/disk.cfg /etc/nagios-plugins/config/disk.cfg
*** /etc/nagios-plugins/config.orig/disk.cfg Mon Mar 7 05:33:30 2005
--- /etc/nagios-plugins/config/disk.cfg Mon May 9 22:55:20 2005
***************
*** 5,14 ****
--- 5,77 ----
}
+ # 'check_all_disks' command definition
+ define command{
+ command_name check_all_disks
+ command_line /usr/lib/nagios/plugins/check_disk -w $ARG1$ -c $ARG2$
+ }
+
+
# 'ssh_disk' command definition
define command{
command_name ssh_disk
command_line /usr/lib/nagios/plugins/check_by_ssh -H $HOSTADDRESS$ -C '/usr/lib/nagios/plugins/check_disk -w $ARG1$ -c $ARG2$ -p $ARG3$'
+ }
+
+
+ # 'check_disk_smb' command definition
+ define command{
+ command_name check_disk_smb
+ command_line /usr/lib/nagios/plugins/check_disk_smb -H "$ARG1$" -s $ARG2$
+ }
+
+
+ # 'check_disk_smb_workgroup' command definition
+ define command{
+ command_name check_disk_smb_workgroup
+ command_line /usr/lib/nagios/plugins/check_disk_smb -H "$ARG1$" -s $ARG2$ -W $ARG3$
+ }
+
+
+ # 'check_disk_smb_host' command definition
+ define command{
+ command_name check_disk_smb_host
+ command_line /usr/lib/nagios/plugins/check_disk_smb -a $HOSTADDRESS$ -H "$ARG1$" -s $ARG2$
+ }
+
+
+ # 'check_disk_smb_workgroup_host' command definition
+ define command{
+ command_name check_disk_smb_workgroup_host
+ command_line /usr/lib/nagios/plugins/check_disk_smb -a $HOSTADDRESS$ -H "$ARG1$" -s $ARG2$ -W $ARG3$
+ }
+
+
+ # 'check_disk_smb_user' command definition
+ define command{
+ command_name check_disk_smb_user
+ command_line /usr/lib/nagios/plugins/check_disk_smb -H "$ARG1$" -s $ARG2$ -u $ARG3$ -p $ARG4$
+ }
+
+
+ # 'check_disk_smb_workgroup_user' command definition
+ define command{
+ command_name check_disk_smb_workgroup_user
+ command_line /usr/lib/nagios/plugins/check_disk_smb -H "$ARG1$" -s $ARG2$ -W $ARG3$ -u $ARG4$ -p $ARG5$
+ }
+
+
+ # 'check_disk_smb_host_user' command definition
+ define command{
+ command_name check_disk_smb_host_user
+ command_line /usr/lib/nagios/plugins/check_disk_smb -a $HOSTADDRESS$ -H "$ARG1$" -s $ARG2$ -u $ARG3$ -p $ARG4$
+ }
+
+
+ # 'check_disk_smb_workgroup_host_user' command definition
+ define command{
+ command_name check_disk_smb_workgroup_host_user
+ command_line /usr/lib/nagios/plugins/check_disk_smb -a $HOSTADDRESS$ -H "$ARG1$" -s $ARG2$ -W $ARG3$ -u $ARG4$ -p $ARG5$
}
diff -rcN /etc/nagios-plugins/config.orig/http.cfg /etc/nagios-plugins/config/http.cfg
*** /etc/nagios-plugins/config.orig/http.cfg Mon Mar 7 05:33:30 2005
--- /etc/nagios-plugins/config/http.cfg Sat May 7 06:51:01 2005
***************
*** 19,25 ****
# 'check_https' command definition
define command{
! command_name check_https
command_line /usr/lib/nagios/plugins/check_http --ssl -H $HOSTADDRESS$ -I $HOSTADDRESS$
}
--- 19,31 ----
# 'check_https' command definition
define command{
! command_name check_https
command_line /usr/lib/nagios/plugins/check_http --ssl -H $HOSTADDRESS$ -I $HOSTADDRESS$
+ }
+
+ # 'check_https_auth' command definition
+ define command{
+ command_name check_https_auth
+ command_line /usr/lib/nagios/plugins/check_http --ssl -H $HOSTADDRESS$ -I $HOSTADDRESS$ -a $ARG1$
}
diff -rcN /usr/lib/nagios/plugins.orig/check_disk_smb /usr/lib/nagios/plugins/check_disk_smb
*** /usr/lib/nagios/plugins.orig/check_disk_smb Mon Mar 7 05:33:28 2005
--- /usr/lib/nagios/plugins/check_disk_smb Thu May 19 00:15:44 2005
***************
*** 23,29 ****
use POSIX;
use strict;
use Getopt::Long;
! use vars qw($opt_P $opt_V $opt_h $opt_H $opt_s $opt_W $opt_u $opt_p $opt_w $opt_c $verbose);
use vars qw($PROGNAME);
use lib "/usr/lib/nagios/plugins" ;
use utils qw($TIMEOUT %ERRORS &print_revision &support &usage);
--- 23,29 ----
use POSIX;
use strict;
use Getopt::Long;
! use vars qw($opt_P $opt_V $opt_h $opt_H $opt_s $opt_W $opt_u $opt_p $opt_w $opt_c $opt_a $verbose);
use vars qw($PROGNAME);
use lib "/usr/lib/nagios/plugins" ;
use utils qw($TIMEOUT %ERRORS &print_revision &support &usage);
***************
*** 49,55 ****
"u=s" => \$opt_u, "username=s" => \$opt_u,
"s=s" => \$opt_s, "share=s" => \$opt_s,
"W=s" => \$opt_W, "workgroup=s" => \$opt_W,
! "H=s" => \$opt_H, "hostname=s" => \$opt_H);
if ($opt_V) {
print_revision($PROGNAME,'$Revision: 1.10 $'); #'
--- 49,56 ----
"u=s" => \$opt_u, "username=s" => \$opt_u,
"s=s" => \$opt_s, "share=s" => \$opt_s,
"W=s" => \$opt_W, "workgroup=s" => \$opt_W,
! "H=s" => \$opt_H, "hostname=s" => \$opt_H,
! "a=s" => \$opt_a, "address=s" => \$opt_a);
if ($opt_V) {
print_revision($PROGNAME,'$Revision: 1.10 $'); #'
***************
*** 65,71 ****
# Options checking
($opt_H) || ($opt_H = shift) || usage("Host name not specified\n");
! my $host = $1 if ($opt_H =~ /^([-_.A-Za-z0-9]+\$?)$/);
($host) || usage("Invalid host: $opt_H\n");
($opt_s) || ($opt_s = shift) || usage("Share volume not specified\n");
--- 66,72 ----
# Options checking
($opt_H) || ($opt_H = shift) || usage("Host name not specified\n");
! my $host = $1 if ($opt_H =~ /^([-_.A-Za-z0-9 ]+\$?)$/);
($host) || usage("Invalid host: $opt_H\n");
($opt_s) || ($opt_s = shift) || usage("Share volume not specified\n");
***************
*** 105,110 ****
--- 106,113 ----
my $workgroup = $1 if (defined($opt_W) && $opt_W =~ /(.*)/);
+ my $address = $1 if (defined($opt_a) && $opt_a =~ /(.*)/);
+
# end of options checking
***************
*** 123,132 ****
# Execute an "ls" on the share using smbclient program
# get the results into $res
if (defined($workgroup)) {
! $res = qx/$smbclient \/\/$host\/$share $pass -W $workgroup -U $user $smbclientoptions -c ls/;
} else {
! print "$smbclient " . "\/\/$host\/$share" ." $pass -U $user $smbclientoptions -c ls\n" if ($verbose);
! $res = qx/$smbclient \/\/$host\/$share $pass -U $user $smbclientoptions -c ls/;
}
#Turn off alarm
alarm(0);
--- 126,146 ----
# Execute an "ls" on the share using smbclient program
# get the results into $res
if (defined($workgroup)) {
! if (defined($address)) {
! print "$smbclient " . "\/\/$host\/$share" ." $pass -W $workgroup -U $user $smbclientoptions -I $address -c ls\n" if ($verbose);
! $res = qx/$smbclient "\/\/$host\/$share" $pass -W $workgroup -U $user $smbclientoptions -I $address -c ls/;
! } else {
! print "$smbclient " . "\/\/$host\/$share" ." $pass -W $workgroup -U $user $smbclientoptions -c ls\n" if ($verbose);
! $res = qx/$smbclient "\/\/$host\/$share" $pass -W $workgroup -U $user $smbclientoptions -c ls/;
! }
} else {
! if (defined($address)) {
! print "$smbclient " . "\/\/$host\/$share" ." $pass -U $user $smbclientoptions -I $address -c ls\n" if ($verbose);
! $res = qx/$smbclient "\/\/$host\/$share" $pass -U $user $smbclientoptions -I $address -c ls/;
! } else {
! print "$smbclient " . "\/\/$host\/$share" ." $pass -U $user $smbclientoptions -c ls\n" if ($verbose);
! $res = qx/$smbclient "\/\/$host\/$share" $pass -U $user $smbclientoptions -c ls/;
! }
}
#Turn off alarm
alarm(0);
***************
*** 231,237 ****
sub print_usage () {
print "Usage: $PROGNAME -H <host> -s <share> -u <user> -p <password>
! -w <warn> -c <crit> [-W <workgroup>] [-P <port>]\n";
}
sub print_help () {
--- 245,251 ----
sub print_usage () {
print "Usage: $PROGNAME -H <host> -s <share> -u <user> -p <password>
! -w <warn> -c <crit> [-W <workgroup>] [-P <port>] [-a <IP>]\n";
}
sub print_help () {
***************
*** 249,254 ****
--- 263,270 ----
Share name to be tested
-W, --workgroup=STRING
Workgroup or Domain used (Defaults to \"WORKGROUP\")
+ -a, --address=IP
+ IP-address of HOST (only necessary if HOST is in another network)
-u, --user=STRING
Username to log in to server. (Defaults to \"guest\")
-p, --password=STRING
diff -rcN /usr/lib/nagios/plugins.orig/check_log /usr/lib/nagios/plugins/check_log
*** /usr/lib/nagios/plugins.orig/check_log Mon Mar 7 05:33:28 2005
--- /usr/lib/nagios/plugins/check_log Tue May 10 00:10:23 2005
***************
*** 62,73 ****
ECHO="/bin/echo"
GREP="/bin/grep"
! DIFF="/bin/diff"
! TAIL="/bin/tail"
CAT="/bin/cat"
RM="/bin/rm"
! PROGNAME=`/bin/basename $0`
PROGPATH=`echo $0 | /bin/sed -e 's,[\\/][^\\/][^\\/]*$,,'`
REVISION=`echo '$Revision: 1.4 $' | /bin/sed -e 's/[^0-9.]//g'`
--- 62,73 ----
ECHO="/bin/echo"
GREP="/bin/grep"
! DIFF="/usr/bin/diff"
! TAIL="/usr/bin/tail"
CAT="/bin/cat"
RM="/bin/rm"
! PROGNAME=`/usr/bin/basename $0`
PROGPATH=`echo $0 | /bin/sed -e 's,[\\/][^\\/][^\\/]*$,,'`
REVISION=`echo '$Revision: 1.4 $' | /bin/sed -e 's/[^0-9.]//g'`
diff -rcN /usr/lib/nagios/plugins.orig/check_mailq /usr/lib/nagios/plugins/check_mailq
*** /usr/lib/nagios/plugins.orig/check_mailq Mon Mar 7 05:33:29 2005
--- /usr/lib/nagios/plugins/check_mailq Wed May 18 23:52:33 2005
***************
*** 40,46 ****
sub print_usage ();
sub process_arguments ();
! $ENV{'PATH'}='';
$ENV{'BASH_ENV'}='';
$ENV{'ENV'}='';
$PROGNAME = "check_mailq";
--- 40,46 ----
sub print_usage ();
sub process_arguments ();
! #$ENV{'PATH'}='';
$ENV{'BASH_ENV'}='';
$ENV{'ENV'}='';
$PROGNAME = "check_mailq";
---------------------------------------
Received: (at 310780-close) by bugs.debian.org; 31 Oct 2005 22:39:03 +0000
>From katie at spohr.debian.org Mon Oct 31 14:39:02 2005
Return-path: <katie at spohr.debian.org>
Received: from katie by spohr.debian.org with local (Exim 3.36 1 (Debian))
id 1EWiCL-0006no-00; Mon, 31 Oct 2005 14:32:13 -0800
From: sean finney <seanius at debian.org>
To: 310780-close at bugs.debian.org
X-Katie: $Revision: 1.56 $
Subject: Bug#310780: fixed in nagios-plugins 1.4.2-5
Message-Id: <E1EWiCL-0006no-00 at spohr.debian.org>
Sender: Archive Administrator <katie at spohr.debian.org>
Date: Mon, 31 Oct 2005 14:32:13 -0800
Delivered-To: 310780-close at bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level:
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER
autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-CrossAssassin-Score: 2
Source: nagios-plugins
Source-Version: 1.4.2-5
We believe that the bug you reported is fixed in the latest version of
nagios-plugins, which is due to be installed in the Debian FTP archive:
nagios-plugins-basic_1.4.2-5_i386.deb
to pool/main/n/nagios-plugins/nagios-plugins-basic_1.4.2-5_i386.deb
nagios-plugins-standard_1.4.2-5_i386.deb
to pool/main/n/nagios-plugins/nagios-plugins-standard_1.4.2-5_i386.deb
nagios-plugins_1.4.2-5.diff.gz
to pool/main/n/nagios-plugins/nagios-plugins_1.4.2-5.diff.gz
nagios-plugins_1.4.2-5.dsc
to pool/main/n/nagios-plugins/nagios-plugins_1.4.2-5.dsc
nagios-plugins_1.4.2-5_i386.deb
to pool/main/n/nagios-plugins/nagios-plugins_1.4.2-5_i386.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 310780 at bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
sean finney <seanius at debian.org> (supplier of updated nagios-plugins package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster at debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Mon, 31 Oct 2005 22:35:16 +0100
Source: nagios-plugins
Binary: nagios-plugins nagios-plugins-basic nagios-plugins-standard
Architecture: source i386
Version: 1.4.2-5
Distribution: unstable
Urgency: low
Maintainer: Debian Nagios Maintainer Group <pkg-nagios-devel at lists.alioth.debian.org>
Changed-By: sean finney <seanius at debian.org>
Description:
nagios-plugins - Plugins for the nagios network monitoring and management system
nagios-plugins-basic - Plugins for the nagios network monitoring and management system
nagios-plugins-standard - Plugins for the nagios network monitoring and management system
Closes: 289879 310780 336639
Changes:
nagios-plugins (1.4.2-5) unstable; urgency=low
.
* Sean Finney
- add documentation to README.Debian about the plugins needing setuid
root, why we don't install them setuid root by default, and some
recommended methods for dealing with this (closes: #289879).
- add documentation to README.Debian about the new package split.
- config.h_debiandefaults.dpatch now modifies common.h instead of
config.h.in, because the latter would sometimes cause build hosts
to spontaneously regenerate the file, overwriting our changes.
since all the plugins include common.h too... (closes: #336639).
- include some patches from "F.A.G. Luteijn" <f.a.g.luteijn at knoware.nl>:
* dhcp.cfg (with notes added by me about needing setuid)
* disk.cfg (check_all_disks)
* disk-smb.cfg (seperated check_disk_smb commands)
* http.cfg (check_https_auth)
* check_disk_smb: allow checking disk usage via host addresses.
(closes: #310780).
Files:
3e1917c84548ad959f9aa4b1eea98e93 1018 net extra nagios-plugins_1.4.2-5.dsc
dfce37f36acc8d9f4ddf2a85a9bc8d50 37776 net extra nagios-plugins_1.4.2-5.diff.gz
73601b58b900fdd27de7fe7a0f46dc75 63306 net extra nagios-plugins_1.4.2-5_i386.deb
d1c93b395a05e72997d9e40d667edab6 264646 net extra nagios-plugins-basic_1.4.2-5_i386.deb
6eabd7fa8d8c00543834e89885a52c91 148004 net extra nagios-plugins-standard_1.4.2-5_i386.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
iD8DBQFDZpdtynjLPm522B0RAuaUAKCAtFDJV9FzeLT9B3KtrK1R8uw7QQCeNRUJ
MrzgXzxdabFLKk9O+HqSTZs=
=lAp/
-----END PGP SIGNATURE-----
More information about the Pkg-nagios-devel
mailing list