Bug#408231: [Pkg-nagios-devel] Bug#408231: nagios2-common: the main script /etc/init.d/nagios2 has commented lines about retrying to stop the service

[Marc Haber]

On Thu, Jan 25, 2007 at 11:08:09AM +0200, Teodor wrote:
> On 1/24/07, Marc Haber <mh+debian-packages at zugschlus.de> wrote:
> >On Wed, Jan 24, 2007 at 12:47:40PM +0200, Teodor wrote:
> >> In the main script /etc/init.d/nagios2 we have these lines:
> >> ...
> >> In most cases the 'stop' action is working only with the SIG_TERM (15)
> >> send to the running process, but it would be good to retry stopping the
> >> service in the case the first attempt failed.
> >>
> >> It seems to me that the code is commented by mistake, otherwise it would
> >> be deleted from the main script.
> >
> >I suspect that I copied that code from some other packages and then
> >left it commented out just in case that nagios needs this more
> >elaborate handling as well.
> >
> 
> Do you consider that 'nagios' doesn't need stop action retrying after
> the first attempt?

I think that it stops reliably, and it does so fast enough. At least I
have not made different experiences, and have not heard differently.

> >fwiw, I did not find any revision of the init script in svn that had
> >this code present _and_ enabled. I am now tempted to treat this as a
> >non-bug and close it.
> >
> >What exactly do you suggest doing?
> 
> I suggest to do one of the following:
> 1. if this code is not necessary it should be removed from the script;

I'll think about this. Either the code will vanish, or there will be
an appropriate comment about why it is still there.

Greetings
Marc

-- 
-----------------------------------------------------------------------------
Marc Haber         | "I don't trust Computers. They | Mailadresse im Header
Mannheim, Germany  |  lose things."    Winona Ryder | Fon: *49 621 72739834
Nordisch by Nature |  How to make an American Quilt | Fax: *49 621 72739835