[Pkg-nagios-devel] Bug#565496: Invalid logic sourcing init-functions

[Michael Welle]

Package: nagios3
Version: 3.2.0-4

The logic for sourcing the file init-functions seems to be odd:

if ! [ -x "/lib/lsb/init-functions" ]; then
  . /lib/lsb/init-functions
else
  echo "E: /lib/lsb/init-functions not found, lsb-base (>= 3.0-6) needed"
  exit 1
fi

The file is not sourced if it exists, but has its execute bits set. On
the other hand the script tries to source the file if it doesn't exist
at all. It should be sufficient to just test if the file is readable.

Regards
hmw

-- 
biff4emacsen - A biff-like tool for (X)Emacs
http://www.c0t0d0s0.de/biff4emacsen/biff4emacsen.html
Flood - Your friendly network packet generator
http://www.c0t0d0s0.de/flood/flood.html