[Pkg-nagios-devel] Bug#578333: Bug#578333: check_smtp HELO bad default and -F missing from --help

[Jan Wagner]

On Monday 19 April 2010 01:06:40 Josip Rodin wrote:
> I noticed our check_smtp was sending garbage in HELO,
>
> % /usr/lib/nagios/plugins/check_smtp -v 127.0.0.1 | head -1
> HELOCMD: HELO shortmachinename
>
> When is it ever a good idea to send the unqualified hostname as HELO?
> Doing that to an actual real-world SMTP server just makes Nagios look like
> a spammer :)

citing Holger Weiss from irc:

I'm not sure whether trying to get a FQDN automagically is such a good idea.  
The only reasonable way to do so would be to issue a DNS query asking for the 
PTR record of some IP address.  Given that your system might have multiple 
addresses: which one?
If you have a patch which implements that, and which falls back to using the 
IP address if the lookup fails (as suggested by the RFC), I'd consider it.  
But the standard says that the server MUST accept any garbage.  So, as far as 
I'm concerned, it's quite reasonable for a Nagios plugin to use some dummy 
value and let the users who care configure the FQDN manually.

You can also find another irclog attached.

So ... patches are welcome.

With kind regards, Jan.
-- 
Never write mail to <waja at spamfalle.info>, you have been warned!
-----BEGIN GEEK CODE BLOCK-----
Version: 3.12
GIT d-- s+: a C+++ UL++++ P+ L+++ E--- W+++ N+++ o++ K++ w--- O M V- PS PE Y++
PGP++ t-- 5 X R tv- b+ DI D+ G++ e++ h---- r+++ y++++ 
------END GEEK CODE BLOCK------

-------------- next part --------------
A non-text attachment was scrubbed...
Name: nagios-devel.20100419.log
Type: text/x-log
Size: 3158 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-nagios-devel/attachments/20100729/88b56c17/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.alioth.debian.org/pipermail/pkg-nagios-devel/attachments/20100729/88b56c17/attachment.pgp>