[Pkg-nagios-devel] Bug#677843: [RFR] templates://icinga-web/{icinga-web.templates}

Christian PERRIER bubulle at debian.org
Sun Jun 17 12:58:42 UTC 2012


Please find, for review, the debconf templates and packages descriptions for the icinga-web source package.

This review will last from Sunday, June 17, 2012 to Wednesday, June 27, 2012.

Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.

Your review should be sent as an answer to this mail.

When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.

When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.

Finally, a summary will be sent to the review bug report,
and a mail will be sent to this list with "[BTS]" as a subject tag.

Rationale:
--- icinga-web.old/debian/icinga-web.templates	2012-06-17 10:22:05.989376111 +0200
+++ icinga-web/debian/icinga-web.templates	2012-06-17 14:53:06.495026224 +0200
@@ -1,9 +1,9 @@
 Template: icinga-web/httpd
 Type: multiselect
-Choices: apache2
+__Choices: apache2

I suggest making this translatable. For instance, I would translate
this to "Apache 2" in French. Of course, debconf will anyway always
get the non translated value...

 Default: apache2
-_Description: Apache servers to configure for icinga:
- Please select which Apache servers should be configured for icinga.
+_Description: Apache servers to configure for Icinga:
+ Please select which Apache servers should be configured for Icinga.
  .
  If you would prefer to perform configuration manually, leave all
  servers unselected.

Capitalize "Icinga"?

@@ -11,19 +11,19 @@
 Template: icinga-web/rootpassword
 Type: password
 _Description: Icinga new web administrative password:
- Please provide the password for the user "root" in the webinterface.
+ Please provide the password for the user "root" in Icinga's web interface.
  .
- This is password you need to access the webinterface with the
- default administrative user. After login you will be able
- to create new users and set permissions for the users.
+ This is the password you need to access the web interface with the
+ default administrative user. After login, you will be able
+ to create new users and set their permissions.
  .
- Please be aware that the password will be reset to this password
- after each run of the postinstall process.
+ Please be aware that the password will be reset to this value
+ each time the package is upgraded.

"web interface" in two words

Mention *what* "web interface"

Add a few commas

 
 Template: icinga-web/rootpassword-repeat
 Type: password
-_Description: Please re-enter the password:
- Please enter the same user password again to verify you have typed it
+_Description: Re-enter password to verify:
+ Please enter the same root password again to verify that you have typed it
  correctly.

Use the same wording than other such templates.


-- 



-------------- next part --------------
Template: icinga-web/httpd
Type: multiselect
__Choices: apache2
Default: apache2
_Description: Apache servers to configure for Icinga:
 Please select which Apache servers should be configured for Icinga.
 .
 If you would prefer to perform configuration manually, leave all
 servers unselected.

Template: icinga-web/rootpassword
Type: password
_Description: Icinga new web administrative password:
 Please provide the password for the user "root" in Icinga's web interface.
 .
 This is the password you need to access the web interface with the
 default administrative user. After login, you will be able
 to create new users and set their permissions.
 .
 Please be aware that the password will be reset to this value
 each time the package is upgraded.

Template: icinga-web/rootpassword-repeat
Type: password
_Description: Re-enter password to verify:
 Please enter the same root password again to verify that you have typed it
 correctly.

Template: icinga-web/rootpassword-mismatch
Type: error
_Description: Password input error
 The two passwords you entered were not the same. Please try again.

-------------- next part --------------
--- icinga-web.old/debian/icinga-web.templates	2012-06-17 10:22:05.989376111 +0200
+++ icinga-web/debian/icinga-web.templates	2012-06-17 14:53:06.495026224 +0200
@@ -1,9 +1,9 @@
 Template: icinga-web/httpd
 Type: multiselect
-Choices: apache2
+__Choices: apache2
 Default: apache2
-_Description: Apache servers to configure for icinga:
- Please select which Apache servers should be configured for icinga.
+_Description: Apache servers to configure for Icinga:
+ Please select which Apache servers should be configured for Icinga.
  .
  If you would prefer to perform configuration manually, leave all
  servers unselected.
@@ -11,19 +11,19 @@
 Template: icinga-web/rootpassword
 Type: password
 _Description: Icinga new web administrative password:
- Please provide the password for the user "root" in the webinterface.
+ Please provide the password for the user "root" in Icinga's web interface.
  .
- This is password you need to access the webinterface with the
- default administrative user. After login you will be able
- to create new users and set permissions for the users.
+ This is the password you need to access the web interface with the
+ default administrative user. After login, you will be able
+ to create new users and set their permissions.
  .
- Please be aware that the password will be reset to this password
- after each run of the postinstall process.
+ Please be aware that the password will be reset to this value
+ each time the package is upgraded.
 
 Template: icinga-web/rootpassword-repeat
 Type: password
-_Description: Please re-enter the password:
- Please enter the same user password again to verify you have typed it
+_Description: Re-enter password to verify:
+ Please enter the same root password again to verify that you have typed it
  correctly.
 
 Template: icinga-web/rootpassword-mismatch
-------------- next part --------------
Source: icinga-web
Section: php
Priority: extra
Maintainer: Debian Nagios Maintainer Group <pkg-nagios-devel at lists.alioth.debian.org>
Uploaders: Markus Frosch <markus at lazyfrosch.de>, Alexander Wirt <formorer at debian.org>
Build-Depends: autotools-dev, debhelper (>= 7.0.50~), po-debconf
Standards-Version: 3.9.3
Homepage: http://www.icinga.org
Vcs-Git: git://git.debian.org/git/pkg-nagios/pkg-icinga-web.git
Vcs-Browser: http://git.debian.org/?p=pkg-nagios/pkg-icinga-web.git;a=summary

Package: icinga-web
Architecture: all
Depends: dbconfig-common,
         icinga-core (>= 1.7.0),
         icinga-idoutils (>= 1.7.0),
         php5,
         php5-cli,
         php5-gd,
         php5-mysql | php5-pgsql,
         php5-xsl,
         ucf,
         ${misc:Depends}
Recommends: apache2 | httpd, mysql-client | postgresql-client
Description: host and network monitoring system - modern web interface
 Icinga is a modular monitoring framework for hosts, services, and
 networks, based on the Nagios project. It is designed to be easy to
 understand and modify to fit any need.
 .
 Features include:
  * monitoring of network services via ping, SMTP, POP3, HTTP, NNTP, or
    TCP port;
  * plugin interface to allow for user-developed service checks;
  * contact notifications when problems occur and get resolved (via
    email, pager, or user-defined method)
  * support for proactive problem resolution (handlers can be defined to
    be run during service or host events);
  * web output: current status, notifications, problem history, log
    file, etc.
 .
 This package provides the new webinterface to view Icinga monitoring
 results and send commands to the Icinga Core. Host and service status,
 history, notifications and status maps are available to keep a check on
 the health of your network in real-time.

Package: icinga-web-pnp
Architecture: all
Depends: icinga-web (= ${source:Version}), pnp4nagios, ${misc:Depends}
Description: host and network monitoring system - modern web interface plugin for pnp4nagios
 Icinga is a modular monitoring framework for hosts, services, and
 networks, based on the Nagios project. It is designed to be easy to
 understand and modify to fit any need.
 .
 Features include:
  * monitoring of network services via ping, SMTP, POP3, HTTP, NNTP, or
    TCP port;
  * plugin interface to allow for user-developed service checks;
  * contact notifications when problems occur and get resolved (via
    email, pager, or user-defined method)
  * support for proactive problem resolution (handlers can be defined to
    be run during service or host events);
  * web output: current status, notifications, problem history, log
    file, etc.
 .
 This package provides a plugin for Icinga new webinterface integrating
 pnp4nagios into the interface for accessing the pnp4nagio data directly.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-nagios-devel/attachments/20120617/061eaacf/attachment.pgp>


More information about the Pkg-nagios-devel mailing list