[Pkg-nagios-devel] Bug#674024: [RFR] templates://icinga/{icinga-cgi.templates, icinga-common.templates}

[Justin B Rye]

Christian PERRIER wrote:
> Your review should be sent as an answer to this mail.
[...]
>  Template: icinga/check_external_commands
>  Type: boolean
>  Default: false
> -_Description: Icinga check external commands:
> +_Description: Use external commands with Icinga?
> 
> Being a boolean template, it shoul duse interrogative form.
> 
>   Icinga is not configured to look for external commands in the default
>   configuration as a security feature. Enabling external commands will give
>   the web server write access to the nagios command pipe and is required
>   if you want to be able to use the CGI command interface.

Well, "Icinga does not do such-and-such as a security feature" is a
little ambiguous; perhaps we could make it:

     As a security feature, Icinga in its default configuration does not look
     for external commands

Also trimming a final blank line.  I think I've already done my worst
to that control file a couple of years ago - I don't see anything I'd
change; so my patch is just for icinga-common.templates.
-- 
JBR	with qualifications in linguistics, experience as a Debian
	sysadmin, and probably no clue about this particular package
-------------- next part --------------
diff -ru old/icinga-common.templates new/icinga-common.templates
--- old/icinga-common.templates	2012-05-22 19:58:55.535393102 +0100
+++ new/icinga-common.templates	2012-05-26 14:29:47.355392512 +0100
@@ -1,10 +1,10 @@
 Template: icinga/check_external_commands
 Type: boolean
 Default: false
-_Description: Icinga check external commands:
- Icinga is not configured to look for external commands in the default
- configuration as a security feature. Enabling external commands will give
+_Description: Use external commands with Icinga?
+ As a security feature, Icinga in its default configuration does not
+ look for external commands. Enabling external commands will give
  the web server write access to the nagios command pipe and is required
  if you want to be able to use the CGI command interface.
  .
- If unsure, choose no.
+ If unsure, do not enable external commands.
-------------- next part --------------
Template: icinga/check_external_commands
Type: boolean
Default: false
_Description: Use external commands with Icinga?
 As a security feature, Icinga in its default configuration does not
 look for external commands. Enabling external commands will give
 the web server write access to the nagios command pipe and is required
 if you want to be able to use the CGI command interface.
 .
 If unsure, do not enable external commands.