[Pkg-nagios-devel] Bug#674859: [RFR] templates://nagvis/{nagvis.templates}

[Justin B Rye]

Christian PERRIER wrote:
> Your review should be sent as an answer to this mail.
[...]
> +_Description: Monitoring suite used with NagVis:
> + The NagVis package supports Icinga as well as
> + Nagios, using the check-mk-live broker backend.

I prefer hyphenated "back-end", but since that's the only change I'd
make to the file it isn't worth the effort...

In the package descriptions:

> +Description: visualization addon for Nagios or Icinga

Also "add-on", but again never mind.

> + NagVis can be used to visualize Nagios or Icinga data, for instance to display IT
> + processes like a mail system or a network infrastructure.

Rather pedantically, s/like/such as/.  I'm not keen on "IT
processes"... yes, it's a key part of the upstream blurb, but it
sounds as if it's talking about hardware purchase procedures - and
network infrastructure definitely isn't an "IT process".  Since one
of the things it does do according to the website is traffic
visualisation, maybe the best answer is:

    NagVis can be used to visualize Nagios or Icinga data, for instance
    to display network traffic or IT services such as email.

> + Its key features are:

Fear, surprise, ruthless efficiency... no, no.

> +  * Display of single hosts or services;
> +  * Display the state of a host dependent on the state of its services
> +    ("recognize services");

A bit awkward: in "display of", "display" is a noun, but in "display
the state..." it's a verb.  And how does "recognize services" fit in?
Perhaps:

    Its key features are:
     * Display of single hosts or services;
     * Representation of a host dependent on the state of its services;

> +  * Visualization of Host- or Servicegroups with one icon;

Why the caps?

     * Visualization of complete host- or servicegroups with one icon;

> +  * Define Sub-Map icons wich represent a complete NagVis map of
> +    hosts/services/groups in one icon (drill down);

s/wich/which/, but the "define" is just a weak attempt to push in the
direction of verbs.  And this doesn't communicate what a "Sub-Map
icon" is supposed to be, which rather reduces its impace as a
"feature".  Maybe we could simplify it right down to:

     * Organization of hosts/services/groups into Sub-Map icons;

> +  * Visualization of complete IT Processes using self drawn graphics.

Visualisation of hardware purchase procedures using graphics that draw
themselves (©1948 MC Escher).

     * Graphical representation of complete IT systems.

>  Package: nagvis-demos
>  Architecture: all
>  Depends: ${misc:Depends}, nagvis (= ${source:Version})
> +Description: demo Mapgs for NagVis

Take out the surplus letter in "mapgs" and there's plenty of room:

   Description: visualization addon for Nagios or Icinga - demo maps
    NagVis can be used to visualize Nagios or Icinga data, for instance
    to display network traffic or IT services such as email.
    .
    Its key features are:
     * Display of single hosts or services;
     * Representation of a host dependent on the state of its services;
     * Visualization of complete host- or servicegroups with one icon;
     * Organization of hosts/services/groups into Sub-Map icons;
     * Graphical representation of complete IT systems.
     .
> +  This package provides some demonstration maps.

It's a pity Nagios isn't still called NetSaint - they could have given
this some name connected with holy icons.
-- 
JBR	with qualifications in linguistics, experience as a Debian
	sysadmin, and probably no clue about this particular package
-------------- next part --------------
diff -ru nagvis-1.6.4.dfsg.1.pristine/debian/control nagvis-1.6.4.dfsg.1/debian/control
--- nagvis-1.6.4.dfsg.1.pristine/debian/control	2012-05-23 11:13:09.000000000 +0100
+++ nagvis-1.6.4.dfsg.1/debian/control	2012-05-28 17:50:29.463726455 +0100
@@ -13,36 +13,29 @@
 Architecture: all
 Depends: ${misc:Depends}, php5-common (>= 5.3.0), libapache2-mod-php5, php5-gd, ucf, graphviz, php5-sqlite, php-net-socket, php-gettext, check-mk-livestatus
 Suggests: nagvis-demos
-Description: Visualization addon for Nagios or Icinga
- NagVis can be used to visualize Nagios or Icinga Data, e.g. to display IT
- processes like  a mail system or a network infrastructure.
+Description: visualization addon for Nagios or Icinga
+ NagVis can be used to visualize Nagios or Icinga data, for instance
+ to display network traffic or IT services such as email.
  .
- Key features are:
- .
-  * Display of single Hosts or Services
-  * Display the state of a Host dependent on the state of its services
-    ("recognize services")
-  * Visualization of Host- or Servicegroups with one icon
-  * Define Sub-Map icons wich represent a complete NagVis Map of
-    Hosts/Services/Groups in one icon (drill down)
-  * Visualization of complete IT Processes using self drawn graphics
+ Its key features are:
+  * Display of single hosts or services;
+  * Representation of a host dependent on the state of its services;
+  * Visualization of complete host- or servicegroups with one icon;
+  * Organization of hosts/services/groups into Sub-Map icons;
+  * Graphical representation of complete IT systems.
 
 Package: nagvis-demos
 Architecture: all
 Depends: ${misc:Depends}, nagvis (= ${source:Version})
-Description: Demo Mapgs for NagVis
- NagVis can be used to visualize Nagios or Icinga Data, e.g. to display IT
- processes like  a mail system or a network infrastructure.
+Description: visualization addon for Nagios or Icinga - demo maps
+ NagVis can be used to visualize Nagios or Icinga data, for instance
+ to display network traffic or IT services such as email.
  .
- Key features are:
+ Its key features are:
+  * Display of single hosts or services;
+  * Representation of a host dependent on the state of its services;
+  * Visualization of complete host- or servicegroups with one icon;
+  * Organization of hosts/services/groups into Sub-Map icons;
+  * Graphical representation of complete IT systems.
  .
-  * Display of single Hosts or Services
-  * Display the state of a Host dependent on the state of its services
-    ("recognize services")
-  * Visualization of Host- or Servicegroups with one icon
-  * Define Sub-Map icons wich represent a complete NagVis Map of
-    Hosts/Services/Groups in one icon (drill down)
-  * Visualization of complete IT Processes using self drawn graphics
-  .
-  This package contains some demonstration maps.
-
+ This package provides some demonstration maps.
diff -ru nagvis-1.6.4.dfsg.1.pristine/debian/nagvis.templates nagvis-1.6.4.dfsg.1/debian/nagvis.templates
--- nagvis-1.6.4.dfsg.1.pristine/debian/nagvis.templates	2012-05-23 11:13:09.000000000 +0100
+++ nagvis-1.6.4.dfsg.1/debian/nagvis.templates	2012-05-28 16:19:23.775392432 +0100
@@ -2,21 +2,20 @@
 Type: select
 Default: icinga
 Choices: icinga, nagios, other
-_Description: For which monitoring suite should NagVis be configured?
- This NagVis package supports the monitoring suites Icinga as well as
- well as Nagios using the check-mk-live broker backend.  please choose the,
- respective entry.  
+_Description: Monitoring suite used with NagVis:
+ The NagVis package supports Icinga as well as
+ Nagios, using the check-mk-live broker backend.
  .
  If you would like to use NagVis with a different backend or a different
- monitoring suite, please choose "other".  You'll have to configure it
+ monitoring suite, please choose "other". You'll have to configure it
  manually.
 
 Template: nagvis/delete_on_purge
 Type: boolean
 Default: false
-_Description: Should the user created NagVis data be removed?
- During usage NagVis creates some file in /var/cache/nagvis and and
- /etc/nagvis (e.g. background images and map files), including a small
- database for authentification.  If you don't need any of these files,
+_Description: Delete NagVis data when purging the package?
+ NagVis creates files in /var/cache/nagvis and
+ /etc/nagvis (for instance background images and map files), including a small
+ database for authentification. If you don't need any of these files,
  they can be removed now, or you may want to keep them and clean up by hand
  later.
-------------- next part --------------
Source: nagvis
Section: net
Priority: extra
Maintainer: Debian Nagios Maintainer Group <pkg-nagios-devel at lists.alioth.debian.org>
Uploaders: Jan Wagner <waja at cyconet.org>, Alexander Wirt <formorer at debian.org>, Alexander Reichle-Schmehl <tolimar at debian.org>
Build-Depends: debhelper (>= 7.0.50~), quilt, po-debconf
Standards-Version: 3.9.3
Homepage: http://www.nagvis.org
Vcs-Svn: svn://svn.debian.org/svn/pkg-nagios/nagvis/trunk/
Vcs-Browser: http://svn.debian.org/wsvn/pkg-nagios/nagvis/trunk/

Package: nagvis
Architecture: all
Depends: ${misc:Depends}, php5-common (>= 5.3.0), libapache2-mod-php5, php5-gd, ucf, graphviz, php5-sqlite, php-net-socket, php-gettext, check-mk-livestatus
Suggests: nagvis-demos
Description: visualization addon for Nagios or Icinga
 NagVis can be used to visualize Nagios or Icinga data, for instance
 to display network traffic or IT services such as email.
 .
 Its key features are:
  * Display of single hosts or services;
  * Representation of a host dependent on the state of its services;
  * Visualization of complete host- or servicegroups with one icon;
  * Organization of hosts/services/groups into Sub-Map icons;
  * Graphical representation of complete IT systems.

Package: nagvis-demos
Architecture: all
Depends: ${misc:Depends}, nagvis (= ${source:Version})
Description: visualization addon for Nagios or Icinga - demo maps
 NagVis can be used to visualize Nagios or Icinga data, for instance
 to display network traffic or IT services such as email.
 .
 Its key features are:
  * Display of single hosts or services;
  * Representation of a host dependent on the state of its services;
  * Visualization of complete host- or servicegroups with one icon;
  * Organization of hosts/services/groups into Sub-Map icons;
  * Graphical representation of complete IT systems.
 .
 This package provides some demonstration maps.
-------------- next part --------------
Template: nagvis/monitoring_system
Type: select
Default: icinga
Choices: icinga, nagios, other
_Description: Monitoring suite used with NagVis:
 The NagVis package supports Icinga as well as
 Nagios, using the check-mk-live broker backend.
 .
 If you would like to use NagVis with a different backend or a different
 monitoring suite, please choose "other". You'll have to configure it
 manually.

Template: nagvis/delete_on_purge
Type: boolean
Default: false
_Description: Delete NagVis data when purging the package?
 NagVis creates files in /var/cache/nagvis and
 /etc/nagvis (for instance background images and map files), including a small
 database for authentification. If you don't need any of these files,
 they can be removed now, or you may want to keep them and clean up by hand
 later.