[Pkg-nagios-devel] Bug#715730: Bug#715730: [Mayhem] Bug report on nagios-plugins-basic: check_by_ssh crashes with exit status 139

[Jan Wagner]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Jim,

Am 22.07.2013 05:11, schrieb Jim Barber:
> I believe the problem is caused by the 'fix' to bug 709297.

there is no relation between those bugs. Bug #715730 is about a
command definition, this bug is about crashing the check_by_ssh binary
with garbage in as value.

> The package maintainer has tried to introduce the ability to pass 
> parameters to Nagios checks by changing them from:
> 
> command_line    /usr/lib/nagios/plugins/check_ssh '$HOSTADDRESS$'
> 
> to:
> 
> command_line    /usr/lib/nagios/plugins/check_ssh '$HOSTADDRESS$'
> '$ARG1$'
> 
> If no extra arguments are passed, it forces an empty parameter to
> be passed to the command which causes a problem.
> 
> I suspect the fix it not to wrap the $ARG1$ within quotes like so:
> 
> command_line    /usr/lib/nagios/plugins/check_ssh '$HOSTADDRESS$'
> $ARG1$
> 
> This means the parameters passed by the user can still be done, but
> if nothing was passed, does not result in an empty positional
> parameter being passed to the command.

Are you in troubles with check_by_ssh in some other ways? If so, it
would be cool to report it into a new bug report.

Many thanks, Jan.
- -- 
Never write mail to <waja at spamfalle.info>, you have been warned!
- -----BEGIN GEEK CODE BLOCK-----
Version: 3.12
GIT d-- s+: a C+++ UL++++ P+ L+++ E--- W+++ N+++ o++ K++ w--- O M V-
PS PE Y++
PGP++ t-- 5 X R tv- b+ DI D+ G++ e++ h---- r+++ y++++
- ------END GEEK CODE BLOCK------
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iD8DBQFR7NfI9u6Dud+QFyQRAkeYAKCFQuyStOwXaHsIUdoi8vwzry3O3ACfUyCh
yrB8F5ufcZShG6eFxPwubo0=
=X9So
-----END PGP SIGNATURE-----