[Pkg-nagios-devel] Bug#665422: nagios-nrpe-server: init-script doesn't notice when starting the daemon fails, pid file is left inconsistent

[Sebastiaan Couwenberg]

Control: found nagios-nrpe/3.0.1-1~exp1

On Sat, 24 Mar 2012 02:14:00 +0100 Christoph Anton Mitterer wrote:
> Maybe this is an upstream issue.

It doesn't look like it, the init script is specific to the Debian package.

> I noticed that when nrpe startup in daemon mode fails (e.g. due
> to a wrongly set config option), the init script doesn't notice
> and fail.
> Also the pid file isn't cleanly removed then, which could mean
> that another process is later on wrongly killed.

The init script indeed doesn't handle the return value of start_daemon.
Perhaps we should follow the example of munin and double check the
starting and stopping of the daemon. It may also be a good argument to
switch to systemd.

I'm currently undecided what to do about this issue, but leaning towards
the systemd option.

Kind Regards,

Bas

-- 
 GPG Key ID: 4096R/6750F10AE88D4AF1
Fingerprint: 8182 DE41 7056 408D 6146  50D1 6750 F10A E88D 4AF1