[Pkg-nagios-devel] Bug#915212: monitoring-plugins-basic: reproducible build (usrmerge): embeds path of apt-get found via PATH

[Andreas Henriksson]

Package: monitoring-plugins-basic
Version: 2.2-4
Severity: normal
Tags: patch
User: md at linux.it
Usertags: usrmerge

Dear Maintainer,

The package fails to build reproducibly on systems that has merged-usr
vs non-merged. The problem is that you embed the full path of apt-get
in a built and shipped binary. On merged-usr systems /bin is a symlink
to /usr/bin and thus /usr/bin/apt-get can also be found via
/bin/apt-get. Building in /bin/apt-get is undesirable since that path
will not work on non-merged systems.

This can simply be fixed by explicitly specifying which path to use
at build-time and pass that to configure. Please see debdiff attached
for your convenience.

Regards,
Andreas Henriksson
-------------- next part --------------
diff -Nru monitoring-plugins-2.2/debian/changelog monitoring-plugins-2.2/debian/changelog
--- monitoring-plugins-2.2/debian/changelog	2018-05-13 14:04:35.000000000 +0200
+++ monitoring-plugins-2.2/debian/changelog	2018-12-01 19:37:04.000000000 +0100
@@ -1,3 +1,11 @@
+monitoring-plugins (2.2-4.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Pass PATH_TO_APTGET=/usr/bin/apt-get to configure
+    - fixes reproducible build on merged-usr vs non-merged systems.
+
+ -- Andreas Henriksson <andreas at fatal.se>  Sat, 01 Dec 2018 19:37:04 +0100
+
 monitoring-plugins (2.2-4) unstable; urgency=medium
 
   * [97cb3c4] Drop symlinks to removed LEGAL file. (Closes: #856676)
diff -Nru monitoring-plugins-2.2/debian/rules monitoring-plugins-2.2/debian/rules
--- monitoring-plugins-2.2/debian/rules	2018-05-13 14:04:35.000000000 +0200
+++ monitoring-plugins-2.2/debian/rules	2018-12-01 19:36:35.000000000 +0100
@@ -82,6 +82,7 @@
 	# Add here commands to configure the package.
 	# Append 'All warnings', 'Immediate binding' and dpkg-buildflags flags
 	CFLAGS="$$(DEB_CFLAGS_MAINT_APPEND='-Wall -Wl,-z,now' dpkg-buildflags --get CFLAGS)" \
+	PATH_TO_APTGET=/usr/bin/apt-get \
 	PGINCLUDE="-I`pg_config --includedir`" PGLIBS="-lpq -lcrypt" \
 	./configure \
 		--disable-maintainer-mode \