[Pkg-nagios-devel] icinga2_2.6.0-2+deb9u1_source.changes ACCEPTED into proposed-updates->stable-new

[Sebastiaan Couwenberg]

On 12/9/18 8:40 PM, Felix Geyer wrote:
> Hi,
> 
> On 09.12.18 20:06, Sebastiaan Couwenberg wrote:
>> Felix,
>>
>> On 12/9/18 6:49 PM, Debian FTP Masters wrote:
>>>  icinga2 (2.6.0-2+deb9u1) stretch; urgency=medium
>>>  .
>>>    * [0eb3cad] Fix timestamps being stored as local time in PostgreSQL.
>>
>> You still need to push the commits that finalize the changelog and the
>> associated release tag.
>>
>> These should have been pushed before you uploaded the package.
> 
> I'm sorry, I wasn't aware you had such a strict workflow.
> Usually I push the finalized changelog commit and the tag once the package
> has been accepted.

I'm aware of that workflow and I consider it flawed. Development happens
in git, once developments is stopped the changes are pushed to share
them with the rest of the community. If development is finished, the
distribution is set in the changelog, committed, and pushed. The repo
should reflect the state of the package development, if the archive has
changes that the repo does not, the state of the package in the repo is
skewed.

Since tags can be deleted and force pushed, you shouldn't wait for the
package to be accepted to tag it and push the tags. I don't consider
waiting for acceptance a good idea, because a long time can pass between
the upload and acceptance which may cause one to forget to tag the
release. Better to just tag and push before upload, and replace the tag
if the upload was rejected and needed additional changes. Or just
increase the revision and remove the need to change the tag.

> I have now pushed said commit.

Thanks, that just leaves the release tag.

Kind Regards,

Bas

-- 
 GPG Key ID: 4096R/6750F10AE88D4AF1
Fingerprint: 8182 DE41 7056 408D 6146  50D1 6750 F10A E88D 4AF1