[Pkg-nagios-devel] icinga2 backport?

[Bas Couwenberg]

On 2018-10-03 12:38, Chris Boot wrote:
> On 03/10/2018 11:22, Bas Couwenberg wrote:
>> On 2018-10-03 11:54, Chris Boot wrote:
>>> [taking debian-backports at l.d.o out of Cc]
>>> 
>>> On 30/09/18 10:42, Sebastiaan Couwenberg wrote:
>>>> On 9/30/18 11:20 AM, Chris Boot wrote:
>>>>> On 30/09/18 09:48, Sebastiaan Couwenberg wrote:
>>>>>> On 9/30/18 10:35 AM, Chris Boot wrote:
>>>>>>> I'd find it very useful if there was an icinga2 backport from
>>>>>>> buster to
>>>>>>> stretch-backports. In particular the performance improvements and 
>>>>>>> new
>>>>>>> certificate signing workflow would be useful, but I could see 
>>>>>>> myself
>>>>>>> using the Elasticsearch plugin at some point too.
>>>>>>> 
>>>>>>> icinga2 2.9.1 builds cleanly against stretch; I've been building
>>>>>>> my own
>>>>>>> backports for a little while and haven't run into trouble. I 
>>>>>>> don't
>>>>>>> expect 2.9.2 to be any different.
>>>>>>> 
>>>>>>> icingaweb2 would probably be nice for other users but I don't use
>>>>>>> Debian
>>>>>>> packages for that.
>>>>>>> 
>>>>>>> I'm happy to do the backporting myself if you prefer; just let me
>>>>>>> know.
>>>>>> 
>>>>>> Please coordinate with the Nagios team
>>>>>> <pkg-nagios-devel at lists.alioth.debian.org>.
>>>>> 
>>>>> Of course!
>>>> 
>>>> Don't forget to change the branch in the gbp.conf & Vcs-Git URL if 
>>>> you
>>>> haven't done so already.
>>> [snip]
>>> 
>>> I've prepared my changes in my own forks of the repos before I make 
>>> any
>>> changes to the team's repos. Would you mind reviewing my (very
>>> straightforward) changes to check whether they match any working
>>> practices of the team?
>>> 
>>> https://salsa.debian.org/bootc/pkg-icinga2/commits/stretch-backports
>>> https://salsa.debian.org/bootc/pkg-icingaweb2/commits/stretch-backports
>> 
>> You also need to update the branch in the Vcs-Git URL in the control 
>> file:
>> 
>>  Vcs-Git: https://salsa.debian.org/nagios-team/pkg-icinga2.git -b
>> stretch-backports
>> 
>>  Vcs-Git: https://salsa.debian.org/nagios-team/pkg-icingaweb2.git -b
>> stretch-backports
> 
> Hi Bas,
> 
> Ah that's a syntax that's new to me. I'll use it if that's the
> convention, but can you point me at the documentation for it? I'm 
> curious!

That's defined in Debian Policy 5.6.26. Version Control System (VCS) 
fields:

"
  In the case of Git, the value consists of a URL, optionally followed by 
the
  word -b and the name of a branch in the indicated repository, following 
the
  syntax of the git clone command. If no branch is specified, the 
packaging
  should be on the default branch.
"

https://www.debian.org/doc/debian-policy/ch-controlfields.html#version-control-system-vcs-fields

>>> I'll be testing the changes at the same time to make sure it all
>>> actually works before I upload, of course.
>>> 
>>> For the upload itself I was planning to use dgit, as per
>>> https://spwhitton.name/blog/entry/pushsourcedropin/. Do you have any
>>> objections?
>> 
>> I have no experience with dgit, and AFAIK no one in the team uses it
>> either.
>> 
>> Hence I would prefer if you used git-buildpackage and dput.
> 
> Of course, no problem. In this case dgit just uses git-buildpackage but
> the upload also updates dgit for people who use it. It deals with
> signing the tags and does the upload with dput for you as well. But I
> have no issue with using the more traditional tools, I'm not a dgit 
> user
> other than for uploading stuff.

Using the same workflow as the rest of team is preferred, that way we 
can help each other.

Kind Regards,

Bas