[Pkg-nagios-devel] Bug#1075320: nsca-ng: ftbfs with GCC-14

[Matthias Klose]

Package: src:nsca-ng
Version: 1.6-6
Severity: important
Tags: sid trixie
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-14

[This bug is targeted to the upcoming trixie release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-14/g++-14, but succeeds to build with gcc-13/g++-13. The
severity of this report will be raised before the trixie release.

The full build log can be found at:
http://qa-logs.debian.net/2024/07/01/nsca-ng_1.6-6_unstable_gccexp.log
The last lines of the build log are at the end of this report.

To build with GCC 14, either set CC=gcc-14 CXX=g++-14 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures are new warnings resulting in build failures with
-Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-14/porting_to.html

[...]
gcc -DHAVE_CONFIG_H -I. -I../..  -DSYSCONFDIR='"/etc"' -DLOCALSTATEDIR='"/var"' -I../../src/common -I../../lib       -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -c -o conf.o conf.c
gcc -DHAVE_CONFIG_H -I. -I../..  -DSYSCONFDIR='"/etc"' -DLOCALSTATEDIR='"/var"' -I../../src/common -I../../lib       -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -c -o fifo.o fifo.c
gcc -DHAVE_CONFIG_H -I. -I../..  -DSYSCONFDIR='"/etc"' -DLOCALSTATEDIR='"/var"' -I../../src/common -I../../lib       -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -c -o hash.o hash.c
gcc -DHAVE_CONFIG_H -I. -I../..  -DSYSCONFDIR='"/etc"' -DLOCALSTATEDIR='"/var"' -I../../src/common -I../../lib       -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -c -o nsca-ng.o nsca-ng.c
gcc -DHAVE_CONFIG_H -I. -I../..  -DSYSCONFDIR='"/etc"' -DLOCALSTATEDIR='"/var"' -I../../src/common -I../../lib       -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -c -o server.o server.c
gcc  -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection     -Wl,-z,relro -Wl,-z,now -o nsca-ng auth.o conf.o fifo.o hash.o nsca-ng.o server.o ../common/libcommon.a ../../lib/libcompat.a -lconfuse -lev -lssl -lcrypto -lsystemd  -lbsd   
make[4]: Leaving directory '/<<PKGBUILDDIR>>/src/server'
make[4]: Entering directory '/<<PKGBUILDDIR>>/src'
make[4]: Nothing to be done for 'all-am'.
make[4]: Leaving directory '/<<PKGBUILDDIR>>/src'
make[3]: Leaving directory '/<<PKGBUILDDIR>>/src'
Making all in man
make[3]: Entering directory '/<<PKGBUILDDIR>>/man'
sed -e 's|[@]sysconfdir[@]|/etc|g' -e 's|[@]localstatedir[@]|/var|g' -e 's|[@]version[@]|1.6|g' -e 's|[@]date[@]|March 19, 2019|g' nsca-ng.cfg.in > nsca-ng.cfg.man
sed -e 's|[@]sysconfdir[@]|/etc|g' -e 's|[@]localstatedir[@]|/var|g' -e 's|[@]version[@]|1.6|g' -e 's|[@]date[@]|March 19, 2019|g' send_nsca.cfg.in > send_nsca.cfg.man
sed -e 's|[@]sysconfdir[@]|/etc|g' -e 's|[@]localstatedir[@]|/var|g' -e 's|[@]version[@]|1.6|g' -e 's|[@]date[@]|March 19, 2019|g' nsca-ng.in > nsca-ng.man
sed -e 's|[@]sysconfdir[@]|/etc|g' -e 's|[@]localstatedir[@]|/var|g' -e 's|[@]version[@]|1.6|g' -e 's|[@]date[@]|March 19, 2019|g' send_nsca.in > send_nsca.man
make[3]: Leaving directory '/<<PKGBUILDDIR>>/man'
Making all in etc
make[3]: Entering directory '/<<PKGBUILDDIR>>/etc'
make[3]: Nothing to be done for 'all'.
make[3]: Leaving directory '/<<PKGBUILDDIR>>/etc'
Making all in build-aux
make[3]: Entering directory '/<<PKGBUILDDIR>>/build-aux'
make[3]: Nothing to be done for 'all'.
make[3]: Leaving directory '/<<PKGBUILDDIR>>/build-aux'
Making all in contrib
make[3]: Entering directory '/<<PKGBUILDDIR>>/contrib'
make[3]: Nothing to be done for 'all'.
make[3]: Leaving directory '/<<PKGBUILDDIR>>/contrib'
Making all in perl
make[3]: Entering directory '/<<PKGBUILDDIR>>/perl'
make[3]: Nothing to be done for 'all'.
make[3]: Leaving directory '/<<PKGBUILDDIR>>/perl'
Making all in python
make[3]: Entering directory '/<<PKGBUILDDIR>>/python'
make[3]: Nothing to be done for 'all'.
make[3]: Leaving directory '/<<PKGBUILDDIR>>/python'
Making all in tests
make[3]: Entering directory '/<<PKGBUILDDIR>>/tests'
gcc -DHAVE_CONFIG_H -I. -I..  -I../lib -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -c -o test_nsca.o test_nsca.c
test_nsca.c: In function ‘cat_fifo’:
test_nsca.c:275:21: error: passing argument 1 of ‘close’ makes integer from pointer without a cast [-Wint-conversion]
  275 |         (void)close(fifo);
      |                     ^~~~
      |                     |
      |                     FILE *
In file included from /usr/include/x86_64-linux-gnu/bits/sigstksz.h:24,
                 from /usr/include/signal.h:328,
                 from /usr/include/x86_64-linux-gnu/sys/wait.h:36,
                 from test_nsca.c:66:
/usr/include/unistd.h:358:23: note: expected ‘int’ but argument is of type ‘FILE *’
  358 | extern int close (int __fd);
      |                   ~~~~^~~~
test_nsca.c: In function ‘print_version’:
test_nsca.c:337:15: warning: ignoring return value of ‘system’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  337 |         (void)system("send_nsca -V");
      |               ^~~~~~~~~~~~~~~~~~~~~~
test_nsca.c:338:15: warning: ignoring return value of ‘system’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  338 |         (void)system("nsca-ng -V");
      |               ^~~~~~~~~~~~~~~~~~~~
make[3]: *** [Makefile:358: test_nsca.o] Error 1
make[3]: Leaving directory '/<<PKGBUILDDIR>>/tests'
make[2]: *** [Makefile:380: all-recursive] Error 1
make[2]: Leaving directory '/<<PKGBUILDDIR>>'
make[1]: *** [Makefile:321: all] Error 2
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_build: error: make -j8 returned exit code 2
make: *** [debian/rules:16: binary] Error 25
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2