[Pkg-nagios-devel] Bug#1105779: unblock: icingaweb2/2.12.4-2

[Bas Couwenberg]

Package: release.debian.org
Severity: normal
X-Debbugs-Cc: icingaweb2 at packages.debian.org
Control: affects -1 + src:icingaweb2
User: release.debian.org at packages.debian.org
Usertags: unblock

Please unblock package icingaweb2 to get the php8.4 patch into trixie.

[ Reason ]
The web interface is unusable with php8.4 due to deprecation warnings like those that required a stable update (#1037925).

[ Impact ]
Web interface doesn't work.

[ Tests ]
Manually tested the patch in a VM, as did the user who reported the issue.

[ Risks ]
Low, the changes are simple.

[ Checklist ]
  [ ] all changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [x] attach debdiff against the package in testing

[ Other info ]
The Salsa CI change is not documented in the changelog as it's not relevant to users.

unblock icingaweb2/2.12.4-2
-------------- next part --------------
diff -Nru icingaweb2-2.12.4/debian/changelog icingaweb2-2.12.4/debian/changelog
--- icingaweb2-2.12.4/debian/changelog	2025-03-26 17:21:14.000000000 +0100
+++ icingaweb2-2.12.4/debian/changelog	2025-05-14 18:43:09.000000000 +0200
@@ -1,3 +1,11 @@
+icingaweb2 (2.12.4-2) unstable; urgency=medium
+
+  * Team upload.
+  * Add upstream patch to disable deprecation warnings.
+    (closes: #1105768)
+
+ -- Bas Couwenberg <sebastic at debian.org>  Wed, 14 May 2025 18:43:09 +0200
+
 icingaweb2 (2.12.4-1) unstable; urgency=high
 
   * Team upload.
diff -Nru icingaweb2-2.12.4/debian/.gitlab-ci.yml icingaweb2-2.12.4/debian/.gitlab-ci.yml
--- icingaweb2-2.12.4/debian/.gitlab-ci.yml	2023-09-22 16:22:14.000000000 +0200
+++ icingaweb2-2.12.4/debian/.gitlab-ci.yml	2025-03-26 21:59:32.000000000 +0100
@@ -4,3 +4,6 @@
 
 variables:
   SALSA_CI_ENABLE_BUILD_PACKAGE_TWICE: 1
+
+piuparts:
+  allow_failure: true
diff -Nru icingaweb2-2.12.4/debian/patches/pr5359-error_reporting.patch icingaweb2-2.12.4/debian/patches/pr5359-error_reporting.patch
--- icingaweb2-2.12.4/debian/patches/pr5359-error_reporting.patch	1970-01-01 01:00:00.000000000 +0100
+++ icingaweb2-2.12.4/debian/patches/pr5359-error_reporting.patch	2025-05-14 16:45:12.000000000 +0200
@@ -0,0 +1,36 @@
+Description: Disable deprecation warnings.
+Author: "Alexander A. Klimov" <alexander.klimov at icinga.com>
+Origin: https://github.com/Icinga/icingaweb2/pull/5359
+Bug: https://github.com/Icinga/icingaweb2/issues/5269
+Bug-Debian: https://bugs.debian.org/1105768
+
+--- a/library/Icinga/Application/ApplicationBootstrap.php
++++ b/library/Icinga/Application/ApplicationBootstrap.php
+@@ -568,7 +568,7 @@ abstract class ApplicationBootstrap
+      */
+     protected function setupErrorHandling()
+     {
+-        error_reporting(E_ALL | E_STRICT);
++        error_reporting(getenv('ICINGAWEB_ENVIRONMENT') === 'dev' ? E_ALL : E_ALL & ~E_DEPRECATED & ~E_USER_DEPRECATED);
+         ini_set('display_startup_errors', 1);
+         ini_set('display_errors', 1);
+         set_error_handler(function ($errno, $errstr, $errfile, $errline) {
+@@ -579,7 +579,6 @@ abstract class ApplicationBootstrap
+             switch ($errno) {
+                 case E_NOTICE:
+                 case E_WARNING:
+-                case E_STRICT:
+                 case E_RECOVERABLE_ERROR:
+                     throw new ErrorException($errstr, 0, $errno, $errfile, $errline);
+             }
+--- a/library/Icinga/Application/webrouter.php
++++ b/library/Icinga/Application/webrouter.php
+@@ -8,7 +8,7 @@ use Icinga\Web\Controller\StaticControll
+ use Icinga\Web\JavaScript;
+ use Icinga\Web\StyleSheet;
+ 
+-error_reporting(E_ALL | E_STRICT);
++error_reporting(E_ALL & ~E_DEPRECATED & ~E_USER_DEPRECATED);
+ 
+ if (isset($_SERVER['REQUEST_URI'])) {
+     $ruri = $_SERVER['REQUEST_URI'];
diff -Nru icingaweb2-2.12.4/debian/patches/series icingaweb2-2.12.4/debian/patches/series
--- icingaweb2-2.12.4/debian/patches/series	1970-01-01 01:00:00.000000000 +0100
+++ icingaweb2-2.12.4/debian/patches/series	2025-05-14 16:42:17.000000000 +0200
@@ -0,0 +1 @@
+pr5359-error_reporting.patch