[Pkg-net-snmp-devel] Bug#745828: snmpd: /etc/init.d/snmpd has incorrect sequence of options passed to start-stop-daemon

[Mehul Sanghvi]

Package: snmpd
Version: 5.7.2.1~dfsg-3
Severity: normal

Dear Maintainer,


When stopping snmpd, the following is observed:

# /etc/init.d/snmpd stop
Stopping SNMP services::start-stop-daemon: unable to stat //--retry (No such file or directory)
rm: cannot remove '/run/snmpd.pid': No such file or directory


The modified /etc/init.d/snmpd is included and the patch is given below:

--- snmpd~      2014-04-09 11:08:38.000000000 -0400
+++ snmpd       2014-04-25 11:51:40.010341769 -0400
@@ -52,12 +52,12 @@
     ;;
   stop)
     log_daemon_msg "Stopping SNMP services:"
-    start-stop-daemon --quiet --stop --oknodo --exec --retry 3 /usr/sbin/snmpd && [ ! -f $SNMP_PID ] || rm $SNMP_PID
+    start-stop-daemon --quiet --stop --oknodo --retry 3 --exec /usr/sbin/snmpd && [ ! -f $SNMP_PID ] || rm $SNMP_PID
     log_progress_msg " snmpd"
     ;;
   restart)
     log_daemon_msg "Restarting SNMP services:"
-    start-stop-daemon --quiet --stop --oknodo --exec --retry 3 /usr/sbin/snmpd  && [ ! -f $SNMP_PID ] || rm $SNMP_PID
+    start-stop-daemon --quiet --stop --oknod --retry 3 --exec /usr/sbin/snmpd  && [ ! -f $SNMP_PID ] || rm $SNMP_PID
     if [ "$SNMPDRUN" = "yes" -a -f /etc/snmp/snmpd.conf ]; then
        start-stop-daemon --quiet --start --exec /usr/sbin/snmpd -- $SNMPDOPTS
        log_progress_msg " snmpd"



The --exec option for start-stop-daemon expects to be followed by the executable to be run, not by another option.


-- System Information:
Debian Release: jessie/sid
  APT prefers testing
  APT policy: (990, 'testing')
Architecture: powerpc (ppc)

Kernel: Linux 3.12-1-powerpc-smp (SMP w/2 CPU cores)
Locale: LANG=en_US, LC_CTYPE=en_US (charmap=ISO-8859-1)
Shell: /bin/sh linked to /bin/dash

Versions of packages snmpd depends on:
ii  adduser                3.113+nmu3
ii  debconf [debconf-2.0]  1.5.52
ii  libc6                  2.18-4
ii  libsnmp-base           5.7.2.1~dfsg-3
ii  libsnmp30              5.7.2.1~dfsg-3
ii  lsb-base               4.1+Debian12

snmpd recommends no packages.

Versions of packages snmpd suggests:
pn  snmptrapd  <none>

-- Configuration Files:
/etc/init.d/snmpd changed:
set -e
. /lib/lsb/init-functions
export PATH=/sbin:/usr/sbin:/bin:/usr/bin
test -x /usr/sbin/snmpd || exit 0
OLD_MIBS_DIR="/usr/share/mibs/site:/usr/share/snmp/mibs:/usr/share/mibs/iana:/usr/share/mibs/ietf:/usr/share/mibs/netsnmp"
MIBS_DIR="/usr/share/snmp/mibs:/usr/share/snmp/mibs/iana:/usr/share/snmp/mibs/ietf"
export MIBDIRS="$MIBS_DIR:$OLD_MIBS_DIR"
SNMP_PID="/run/snmpd.pid"
SNMPDRUN="yes"
SNMPDOPTS="-Lsd -Lf /dev/null -p $SNMP_PID"
[ -r /etc/default/snmpd ] && . /etc/default/snmpd
cd /
case "$1" in
  start)
    log_daemon_msg "Starting SNMP services:"
    # remove old symlink with previous version
    if [ -L /var/run/agentx ]; then
	    rm -f /var/run/agentx
    fi
    if [ ! -d /var/run/agentx ]; then
	    mkdir -p /var/run/agentx
    fi
    if [ "$SNMPDRUN" = "yes" -a -f /etc/snmp/snmpd.conf ]; then
	start-stop-daemon --quiet --start --oknodo --exec /usr/sbin/snmpd \
	    -- $SNMPDOPTS
	log_progress_msg " snmpd"
    fi
    ;;
  stop)
    log_daemon_msg "Stopping SNMP services:"
    start-stop-daemon --quiet --stop --oknodo --retry 3 --exec /usr/sbin/snmpd && [ ! -f $SNMP_PID ] || rm $SNMP_PID
    log_progress_msg " snmpd"
    ;;
  restart)
    log_daemon_msg "Restarting SNMP services:"
    start-stop-daemon --quiet --stop --oknod --retry 3 --exec /usr/sbin/snmpd  && [ ! -f $SNMP_PID ] || rm $SNMP_PID
    if [ "$SNMPDRUN" = "yes" -a -f /etc/snmp/snmpd.conf ]; then
	start-stop-daemon --quiet --start --exec /usr/sbin/snmpd -- $SNMPDOPTS
	log_progress_msg " snmpd"
    fi
    ;;
  reload|force-reload)
    log_daemon_msg "Reloading SNMP services:"
    if [ "$SNMPDRUN" = "yes" -a -f /etc/snmp/snmpd.conf ]; then
        start-stop-daemon --quiet --stop --signal 1 \
	    --pidfile "$SNMP_PID" --exec /usr/sbin/snmpd
	log_progress_msg " snmpd"
    fi
    ;;
  status)
    status=0
    if [ "$SNMPDRUN" = "yes" -a -f /etc/snmp/snmpd.conf ]; then
    	status_of_proc /usr/sbin/snmpd snmpd || status=$?
    fi
    exit $status
    ;;
  *)
    echo "Usage: /etc/init.d/snmpd {start|stop|restart|reload|force-reload|status}"
    exit 1
esac
exit 0

/etc/snmp/snmpd.conf [Errno 13] Permission denied: u'/etc/snmp/snmpd.conf'
/etc/snmp/snmptrapd.conf [Errno 13] Permission denied: u'/etc/snmp/snmptrapd.conf'

-- debconf information:
  snmpd/upgradefrom521:
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bug-snmpd-etc-init.d-snmpd-uses-wrong-options.diff
Type: text/x-diff
Size: 938 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-net-snmp-devel/attachments/20140425/f5d1769e/attachment.diff>