[Pkg-net-snmp-devel] Bug#782243: systemd service files for net-snmp

[Raphael Hertzog]

Hi Sam,

thanks for the review.

On Mon, 20 Jun 2016, Sam Tannous wrote:
> Other then that, my "After" was set to "networking.service syslog.service"
> rather then "network.target" because I find the latter does not mean the
> network is actually up and usable.   Also, we opted to not start snmpd
> by default (we make users consciously choose to "enable" and "start" (in
> debian/rules file).

I used network.target because networking.service looks wrong to me: it
works only with ifupdown. And all other systemd services rely on
network.target instead.

$ grep -l -r network.target /lib/systemd/system/* | wc -l
24
$ grep -l -r networking.target /lib/systemd/system/* | wc -l
0

If you have a case where the network is not yet fully configured in
network.target then you should really figure out a fix which ensures that
it's the case instead of working around in other application-level service
file.

syslog.service is useless as that kind of dependency is implicitely
handled via (/dev/log) socket activation.

> I haven't looked at the first patch (diffs of diffs give me a headache...I
> just applied all the patches (via git apply) but I will look at it later
> this week.

You don't need to look at this patch. It's just what is in Debian unstable
already but which is not committed the packaging repository yet.

> Patches 3 and 4 look good but I haven't tested them yet.

I did test "dpkg-buildpackage -A" and "dpkg-buildpackage -B" to ensure my changes
work.

Cheers,
-- 
Raphaël Hertzog ◈ Debian Developer

Support Debian LTS: http://www.freexian.com/services/debian-lts.html
Learn to master Debian: http://debian-handbook.info/get/