[Pkg-netatalk-devel] Comments on netatalk 2.2.5-1

[Chris Boot]

Folks,

So I've reviewed the changes from 2.2.2-1 to 2.2.5-1 and overall I think
the changes are good. I have a few minor nitpicks though.

>From the changelog:

  * Add debug package to control.in
  * Add debian/control generated from control.in with new debug package

In my opinion that should be collapsed into a single line along the
lines of "Add debug package to control.in and regenerate control.in" or
similar.

  * Don't use patch to fix typos in debian/changelog

There is no sign of that in the package anymore, so I think that log
entry should just go away completely.

Any objections to making those changes?

I've also looked over the upstream changes briefly and can't see
anything major we might have missed that we need to tell people about
especially, so that's good too. debdiffs between the binary packages of
2.2.2-1 and 2.2.5-1 are sane as well.

There are, however, a large number of issues reported by lintian that we
should at least consider fixing before we upload, including an error and
some warnings that could be fairly easily fixed.

There's an error for:
E: netatalk: shell-script-fails-syntax-check usr/bin/add_netatalk_printer

This is a bit of an odd one:

bootc at tarquin netatalk $ sh -n contrib/printing/add_netatalk_printer
contrib/printing/add_netatalk_printer: 1:
contrib/printing/add_netatalk_printer: Syntax error: Unterminated quoted
string

Bash has no complaint about the script, and I certainly can't see any
unterminated quoted strings on line 1, so I'm scratching my head about
that one.

Some warnings:

W: netatalk source: syntax-error-in-dep5-copyright line 180: Duplicate
field copyright.
W: netatalk source: ancient-standards-version 3.9.3 (current is 3.9.5)
W: netatalk-dbg: debian-news-entry-has-unknown-version 2.1.2-3
W: netatalk-dbg: debian-changelog-line-too-long line 81

These should all be easily fixable. I'll have a stab at all of the
lintian warnings and see if I can't make some progress on the worst
offenders, then push my changes back to the team branch.

HTH,
Chris

-- 
Chris Boot
debian at bootc.net
GPG: 8467 53CB 1921 3142 C56D  C918 F5C8 3C05 D9CE EEEE