[Pkg-netatalk-devel] Comments on netatalk 2.2.5-1

[Jonas Smedegaard]

Quoting Chris Boot (2014-04-24 14:56:35)
> On 23/04/14 17:25, Jonas Smedegaard wrote:
>> Please commit actual changes separately from auto-generated ones and 
>> meta changes like changelog updates.  That eases e.g. cherry-picking 
>> across branches.
>> 
>> control file is auto-generated from control.in, with this command:
>> 
>>   debian/rules clean DEB_MAINTAINER_MODE=1
>> 
>> Put as first line of the commit message the text as is likely useful 
>> to reuse in changelog, and then (either immediately afterwards or 
>> later, perhaps only once just before releasing the package) run "git 
>> dch -a" and tidy its result.
>
> We should probably document that in README.source or similar. This is 
> very different from how I've been working on other packages, so it'll 
> be useful to have it written down somewhere so that any member of the 
> team can refer to it easily.

I am surprised this is unusual to you. I work like that also in my 
collaboration in Multimedia, Perl, and Javascript teams.

It feels like overkill to me to document all these things for this 
little team, but if you feel the need, I suggest to do it on wiki.d.o.  
Ideally a wiki page only on the git commit style, that can be reused 
across teams that use same style - and then referenced from 
http://wiki.debian.org/CDBS+git-buildpackage (instead of me mirroring 
exact same README.Source file across 350+ packages).


> I do have a slight question regarding your commit 3052f3a9dc7c where 
> you edit the DEP3 patch header. First of all, I think you mean DEP3 
> (patch tagging) rather than DEP5 (copyright format). Second, and this 
> may just be a question of style, but I'm confident my header was in a 
> valid format. I wrote it that way so that it could be easily forwarded 
> upstream, including the S-o-b line, without having to reformat it. It 
> loosely followed the first example on http://dep.debian.net/deps/dep3/ 
> but I'm happy to format them with the alternative syntax if you'd 
> rather.

You are right, I wrongly referred to DEP5 in commit message :-)

I believe your header had 2 flaws:

 * When using "Description:" then multiline text need to be indended
   (unlike the alternate "Subject:").
 * "Signed-off-by:" was renamed 3 days after initial draft of DEP3.

As hinted in the commit message, I dropped rather than correct your 
"Signed-off-by:" as it is arguably pointless to state approval of a 
patch by its author (i.e. that is implied by the very actions of 
authoring + releasing a patch).


 - Jonas

-- 
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 966 bytes
Desc: signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-netatalk-devel/attachments/20140424/8a8cda13/attachment.sig>