[Pkg-netatalk-devel] Bug#772280: netatalk: bashism in /bin/sh script

[Raphael Geissert]

Package: netatalk
Severity: important
Version: 2.2.5-1+b1
User: debian-release at lists.debian.org
Usertags: goal-dash

Hi,

I've ran checkbashisms (from the 'devscripts' package) over the whole
archive and I found that your package has a /bin/sh script that uses a
"bashism".

checkbashisms' output:
> possible bashism in ./usr/bin/add_netatalk_printer line 111 (unsafe echo
> with backslash):
> echo "Enter Unix printer name - [default: ${SUGGEST}] : \c"
> possible bashism in ./usr/bin/add_netatalk_printer line 139 (unsafe echo
> with backslash):
> echo "filters to work.] : \c"
> possible bashism in ./usr/bin/add_netatalk_printer line 147 (unsafe echo
> with backslash):
> echo "face up in the output bin. [N/y] \c"
> possible bashism in ./usr/bin/add_netatalk_printer line 161 (unsafe echo
> with backslash):
>	  echo "all pending jobs!  [Y/n]? \c"
> possible bashism in ./usr/bin/add_netatalk_printer line 179 (unsafe echo
> with backslash):
>     echo "Do you want to share this printer with other machines [Y/n]?\c"
> possible bashism in ./usr/bin/add_netatalk_printer line 305 (enable):
> enable ${UNIXPRINT} || exit 3


Not using bash (or a Debian Policy compliant shell interpreter that doesn't
provide such an extra feature) as /bin/sh is likely to lead to errors or
unexpected behaviours. Please be aware that dash is the default /bin/sh.

Please closely examine the above output and the script, and determine
what the proper severity of the bug is, and adjust it accordingly. If
it's important or greater please hurry to get this fixed for jessie.

Hints about how to fix bashisms can be found at:
https://wiki.ubuntu.com/DashAsBinSh

Thanks in advance,
Raphael Geissert