[pkg-netfilter-team] Bug#1007829: Bug#1007829: arptables - Fails to install: Too many levels of symbolic links: debdiff for NMU in DELAYED/2

[Thomas Goirand]

Hi,

As per discussion on IRC and check of the existing prerm, arptables 
already has the logic in prerm to clean-up old symlinks, so I didn't 
touch it.

Discussing on #debian-devel, it was agreed we need to clean-up eventual 
remainings of the symlink, if they point to /usr/sbin/*, so that's what 
I've done in the attached patch.

I have attached the debdiff for the NMU that I've uploaded to delayed-2. 
Let me know if that's fine, or if you would like me to "dcut rm" the upload.

Cheers,

Thomas Goirand (zigo)
-------------- next part --------------
diff -Nru arptables-0.0.5/debian/arptables.postinst arptables-0.0.5/debian/arptables.postinst
--- arptables-0.0.5/debian/arptables.postinst	2020-05-15 12:14:42.000000000 +0200
+++ arptables-0.0.5/debian/arptables.postinst	2022-04-06 10:30:56.000000000 +0200
@@ -5,14 +5,14 @@
 
 set -e
 
-# compat symlinks for /sbin -> /usr/sbin move, to be dropped in buster+1
+# Clean-up the old compat symlinks for /sbin -> /usr/sbin
 
 if [ "$1" = "configure" ]; then
    LIST="arptables arptables-save arptables-restore"
 
    for i in $LIST; do
-       if [ ! -e "/sbin/$i" ]; then
-	   ln -sf /usr/sbin/$i /sbin/$i
+       if [ -e "/sbin/$i" ] && [ $(readlink /sbin/$i) = /usr/sbin/$i ] ; then
+	   rm /sbin/$i
        fi
    done
 fi
diff -Nru arptables-0.0.5/debian/changelog arptables-0.0.5/debian/changelog
--- arptables-0.0.5/debian/changelog	2020-06-09 17:47:38.000000000 +0200
+++ arptables-0.0.5/debian/changelog	2022-04-06 10:31:00.000000000 +0200
@@ -1,3 +1,11 @@
+arptables (0.0.5-3.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Do not install /sbin/* compat symlink, cleans them if they are still
+    present (Closes: #1007829).
+
+ -- Thomas Goirand <zigo at debian.org>  Wed, 06 Apr 2022 10:31:00 +0200
+
 arptables (0.0.5-3) unstable; urgency=medium
 
   * [9e68e1c] d/tests/control: add isolation-machine restriction to tests