[pkg-netfilter-team] Bug#731638: Wrong diagnosis

[Jeremy Sowden]

Actually, I've just realized that we've all been barking up the wrong
tree here.  The problem has nothing to do with the transition from ulogd
to ulogd2.  For example, here's a fresh install of the package currently
in testing:

  $ apt-cache policy ulogd2
  ulogd2:
    Installed: (none)
    Candidate: 2.0.7-1+b3
    Version table:
       2.0.7-1+b3 990
          990 http://mirror.ox.ac.uk/debian testing/main amd64 Packages
          990 http://ftp.uk.debian.org/debian testing/main amd64 Packages
          990 http://ftp.debian.org/debian testing/main amd64 Packages
           99 http://mirror.ox.ac.uk/debian unstable/main amd64 Packages
           99 http://ftp.uk.debian.org/debian unstable/main amd64 Packages
           99 http://ftp.debian.org/debian unstable/main amd64 Packages
       2.0.7-1+b1 900
          900 http://mirror.ox.ac.uk/debian stable/main amd64 Packages
          900 http://ftp.uk.debian.org/debian stable/main amd64 Packages
          900 http://ftp.debian.org/debian stable/main amd64 Packages
  $ ls -ld /var/log/ulog
  ls: cannot access '/var/log/ulog': No such file or directory
  $ sudo apt-get install ulogd2
  Reading package lists... Done
  Building dependency tree... Done
  Reading state information... Done
  Suggested packages:
    ulogd2-dbi ulogd2-json ulogd2-mysql ulogd2-pcap ulogd2-pgsql ulogd2-sqlite3
  The following NEW packages will be installed:
    ulogd2
  0 upgraded, 1 newly installed, 0 to remove and 0 not upgraded.
  Need to get 0 B/108 kB of archives.
  After this operation, 569 kB of additional disk space will be used.
  Selecting previously unselected package ulogd2.
  (Reading database ... 585103 files and directories currently installed.)
  Preparing to unpack .../ulogd2_2.0.7-1+b3_amd64.deb ...
  Unpacking ulogd2 (2.0.7-1+b3) ...
  Setting up ulogd2 (2.0.7-1+b3) ...
  adduser: Warning: The home dir /var/log/ulog you specified already exists.
  adduser: The home directory `/var/log/ulog' already exists.  Not copying from `/etc/skel'.
  adduser: Warning: The home directory `/var/log/ulog' does not belong to the user you are currently creating.

The problem is the source package lists /var/log/ulog in ulogd2.dirs, so
dh_installdir creates it with ownership `root:root` and mode
`u=rwx,go=rx` and it is present in the binary package:

  $ dpkg-deb --contents /var/cache/apt/archives/ulogd2_2.0.7-1+b3_amd64.deb | grep /var/log/ulog
  drwxr-xr-x root/root         0 2022-10-16 11:37 ./var/log/ulog/

On a fresh install, therefore, when the package is unpacked the
directory is created with the wrong ownership and permissions.
Thereafter, adduser runs and complains about it.

However, since 2.0.5-5, the postinst script has called mkdir to create
the directory again and then fixed up the ownership and permissions, so
although the warning is still present, in the end the directory is
correctly set up.

J.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-netfilter-team/attachments/20221215/13b18c81/attachment.sig>