[Pkg-nginx-maintainers] NGINX MR #21 (update)

[Thomas Ward]

Yep, feel free to include it in Experimental.

I have less reservations about putting things we're not 100% sure about 
and not 100% ready to put into Unstable into Experimental first.

ANd yes, I saw it fixed Hurd!  That's the first time in a while all 
archs get proper builds yay!


Thomas


On 5/9/22 14:48, Jan Mojzis wrote:
> Sure!
> If it's okay, I'll include it in exp1 version.
>
> btw:  hurd build fixed (patch works): 
> https://buildd.debian.org/status/fetch.php?pkg=nginx&arch=hurd-i386&ver=1.20.2-2&stamp=1652120157&raw=0 
> <https://buildd.debian.org/status/fetch.php?pkg=nginx&arch=hurd-i386&ver=1.20.2-2&stamp=1652120157&raw=0>
>
> Jan
>
>
>
>> On 9. 5. 2022, at 17:59, Thomas Ward <teward at thomas-ward.net> wrote:
>>
>> Tagged in Salsa, and pushed to ftp-master.
>>
>> Can you also take a look at 
>> https://salsa.debian.org/nginx-team/nginx/-/merge_requests/22 and 
>> determine if this is sane?  I have no issue dropping the patch **if** 
>> `--with-compat` actually does what the patch does, but today I'm 
>> limited on available cycles due to full time job and "hair on fire" 
>> situations at work this morning.
>>
>>
>> Thomas
>>
>> On 5/9/22 11:51, Jan Mojzis wrote:
>>> Hello,
>>> go ahead!
>>> I've reviewed and tested both patches.
>>>
>>> After that,
>>> I will rebase the experimental branch and prepaire 1.20.2-2exp1
>>>
>>> Have a nice day
>>> Jan
>>>
>>>> On 9. 5. 2022, at 17:18, Thomas Ward <teward at thomas-ward.net> wrote:
>>>>
>>>> https://salsa.debian.org/nginx-team/nginx/-/merge_requests/24/diffs#9c96da0e9f91d7d8937b69b524702c106258f0d1
>>>>
>>>> This is now merged to Master on Salsa, which completes the 1.20.2-2 
>>>> set as we discussed.
>>>>
>>>> Is there any objection to my marking that as done, tagging 1.20.2-2 
>>>> with git-buildpackage (which is the workflow we're using), and then 
>>>> uploading 1.20.2-2 to Unstable?
>>>>
>>>>
>>>> Thomas
>>>>
>>>>
>>>> On 5/9/22 10:21, Jan Mojzis wrote:
>>>>> ok, no problem.
>>>>> Jan
>>>>>
>>>>>
>>>>>> On 9. 5. 2022, at 15:35, Thomas Ward <teward at thomas-ward.net> wrote:
>>>>>>
>>>>>> i am going to say "no" on what is present as is.  I am VERY 
>>>>>> hesitant to add nginx-dev to the unstable packaging as I have not 
>>>>>> tested it and want to more heavily vet it.
>>>>>>
>>>>>> I propose that we add the fixes for the CVE and the hurd fixes 
>>>>>> and get that released as 1.20.2-2.
>>>>>>
>>>>>> I would then like nginx-dev to sit in experimental for a bit as 
>>>>>> 1.20.2-2exp1 so we can do some testing and make sure it can be 
>>>>>> used to permit "additional modules" to be built/tested/packaged 
>>>>>> separately from NGINX source.
>>>>>>
>>>>>> This may sound counterintuitive but I am not 100% sold on the way 
>>>>>> that nginx-dev is packaged that it will work so I want that to 
>>>>>> sit a bit in Experimental for testing first and let us do some 
>>>>>> more experimentation and testing on it.
>>>>>>
>>>>>>
>>>>>> Thomas
>>>>>>
>>>>>>
>>>>>>
>>>>>> Sent from my Galaxy
>>>>>>
>>>>>>
>>>>>> -------- Original message --------
>>>>>> From: Jan Mojzis <jan.mojzis at gmail.com>
>>>>>> Date: 5/9/22 01:38 (GMT-05:00)
>>>>>> To: Thomas Ward <teward at thomas-ward.net>
>>>>>> Subject: NGINX MR #21 (update)
>>>>>>
>>>>>> Hello,
>>>>>> on the weekend I've tested the MR and everything works as expected.
>>>>>> Changes here: 
>>>>>> https://salsa.debian.org/nginx-team/nginx/-/blob/experimental/debian/changelog
>>>>>>
>>>>>> I've tested with modules lua+ndk and everythink works.
>>>>>> I think, it's not necessarry to send this changes to the deb. 
>>>>>> experimental,
>>>>>> and can be safely added to 1.20.2-2.
>>>>>>
>>>>>> I'd like to merge it to the master  tomorrow.
>>>>>>
>>>>>> If You have time, can You please quickly double-check it?
>>>>>>
>>>>>>
>>>>>> Thanks and have a nice day,
>>>>>> Jan
>>>>>>
>>>>>
>>>>
>>>
>>>
>>> _______________________________________________
>>> Pkg-nginx-maintainers mailing list
>>> Pkg-nginx-maintainers at alioth-lists.debian.net
>>> https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-nginx-maintainers
>>
>
>
> _______________________________________________
> Pkg-nginx-maintainers mailing list
> Pkg-nginx-maintainers at alioth-lists.debian.net
> https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-nginx-maintainers
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/pkg-nginx-maintainers/attachments/20220509/3f413635/attachment.htm>