[Pkg-nginx-maintainers] Bug#1028153: libnginx-mod-http-brotli-static: "brotli_static on; " causes "Vary: Accept-Encoding" to be added to every file (including images)

[LeJacq, Jean Pierre]

Package: libnginx-mod-http-brotli-static
Version: 1.0.0~rc-1+b1
Severity: normal

Dear Maintainer,

*** Reporter, please consider answering these questions, where appropriate ***

   * What led up to the situation?

Installed package and enabled following configuration.

brotli_static on;

# brotli off;
# brotli_types
#   application/xhtml+xml
#   application/xml
#   image/svg+xml
#   text/css
#   text/javascript
#   text/plain
#   ;

   * What was the outcome of this action?

brotli compressed files properly served with the header Vary: Accept-Encoding". 
However, all other files that are not compressed also have this header set with 
the same value.

   * What outcome did you expect instead?

Module should only set Vary for brotli compressed files.

This is a known issue:

https://github.com/google/ngx_brotli/issues/97

And there is patch available:

https://github.com/google/ngx_brotli/pull/98

Please consider applying to the Debian release. Without this fix, the module is 
essentially useless.

-- System Information:
Debian Release: 11.4 (Qinux 3.2)
  APT prefers stable-security
  APT policy: (1000, 'stable-security'), (1000, 'stable'), (500, 'stable-
updates'), (100, 'bullseye-fasttrack'), (100, 'bullseye-backports-staging'), 
(100, 'unstable'), (10, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 6.0.0-0.deb11.6-amd64 (SMP w/12 CPU threads; PREEMPT)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE not 
set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

-- 
JP
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: This is a digitally signed message part.
URL: <http://alioth-lists.debian.net/pipermail/pkg-nginx-maintainers/attachments/20230107/482a1022/attachment.sig>