[Pkg-nginx-maintainers] Bug#1042174: libnginx-mod-js: FTBFS: src/njs_iterator.c:358:25: error: storing the address of local variable ‘string_obj’ in ‘*args.value’ [-Werror=dangling-pointer=]

[Lucas Nussbaum]

Source: libnginx-mod-js
Version: 0.7.12-2
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-20230726 ftbfs-trixie

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.


Relevant part (hopefully):
> cc -c -pipe -fPIC -fvisibility=hidden -O -W -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wmissing-prototypes -Werror -g -fexcess-precision=standard -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -fPIC -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security   \
> 	-Isrc -Ibuild -Injs \
> 	-o build/src/njs_iterator.o \
> 	-MMD -MF build/src/njs_iterator.dep -MT build/src/njs_iterator.o \
> 	src/njs_iterator.c
> src/njs_iterator.c: In function ‘njs_object_iterate’:
> src/njs_iterator.c:358:25: error: storing the address of local variable ‘string_obj’ in ‘*args.value’ [-Werror=dangling-pointer=]
>   358 |             args->value = &string_obj;
>       |             ~~~~~~~~~~~~^~~~~~~~~~~~~
> src/njs_iterator.c:300:58: note: ‘string_obj’ declared here
>   300 |     njs_value_t         *value, *entry, prop, character, string_obj;
>       |                                                          ^~~~~~~~~~
> src/njs_iterator.c:293:55: note: ‘args’ declared here
>   293 | njs_object_iterate(njs_vm_t *vm, njs_iterator_args_t *args,
>       |                                  ~~~~~~~~~~~~~~~~~~~~~^~~~
> src/njs_iterator.c: In function ‘njs_object_iterate_reverse’:
> src/njs_iterator.c:522:25: error: storing the address of local variable ‘string_obj’ in ‘*args.value’ [-Werror=dangling-pointer=]
>   522 |             args->value = &string_obj;
>       |             ~~~~~~~~~~~~^~~~~~~~~~~~~
> src/njs_iterator.c:462:58: note: ‘string_obj’ declared here
>   462 |     njs_value_t         *entry, *value, prop, character, string_obj;
>       |                                                          ^~~~~~~~~~
> src/njs_iterator.c:455:63: note: ‘args’ declared here
>   455 | njs_object_iterate_reverse(njs_vm_t *vm, njs_iterator_args_t *args,
>       |                                          ~~~~~~~~~~~~~~~~~~~~~^~~~
> cc1: all warnings being treated as errors
> make[2]: *** [build/Makefile:702: build/src/njs_iterator.o] Error 1


The full build log is available from:
http://qa-logs.debian.net/2023/07/26/libnginx-mod-js_0.7.12-2_unstable.log

All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20230726;users=lucas@debian.org
or:
https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20230726&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.