[Pkg-nginx-maintainers] Bug#1073274: libnginx-mod-js: FTBFS on ppc64el with -O3 and lto enabled
Gianfranco Costamagna
locutusofborg at debian.org
Sat Jun 15 15:18:52 BST 2024
Source: libnginx-mod-js
Version: 0.8.4-1
tags: patch
Hello, I found the package to FTBFS when more optimizations are enabled in gcc/dpkg.
The patch is trivial, just a matter of initializing two variables.
I proposed a patch upstream and sending it for your convenience
diff -Nru libnginx-mod-js-0.8.4/debian/changelog libnginx-mod-js-0.8.4/debian/changelog
--- libnginx-mod-js-0.8.4/debian/changelog 2024-06-14 10:34:41.000000000 +0200
+++ libnginx-mod-js-0.8.4/debian/changelog 2024-06-15 15:53:23.000000000 +0200
@@ -1,3 +1,10 @@
+libnginx-mod-js (0.8.4-2) unstable; urgency=medium
+
+ * Non-maintainer upload
+ * Fix code bugs and warning related to -Wno-error=maybe-uninitialized
+ on ppc64el (Closes: #-1)
+
+ -- Gianfranco Costamagna <locutusofborg at debian.org> Sat, 15 Jun 2024 15:45:17 +0200
+
libnginx-mod-js (0.8.4-1) unstable; urgency=medium
* New upstream version 0.8.4
diff -Nru libnginx-mod-js-0.8.4/debian/patches/738.patch libnginx-mod-js-0.8.4/debian/patches/738.patch
--- libnginx-mod-js-0.8.4/debian/patches/738.patch 1970-01-01 01:00:00.000000000 +0100
+++ libnginx-mod-js-0.8.4/debian/patches/738.patch 2024-06-15 15:53:23.000000000 +0200
@@ -0,0 +1,76 @@
+From 9baca5695881c672bb77862f4e00d63ee0b1ebf0 Mon Sep 17 00:00:00 2001
+From: Gianfranco Costamagna <costamagnagianfranco at yahoo.it>
+Date: Sat, 15 Jun 2024 16:07:33 +0200
+Subject: [PATCH] Update njs_utf8.h and njs_error.c to fix build failures with
+ O3 and lto on ppc64el
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+ build/src/njs_diyfp.o build/src/njs_dtoa.o build/src/njs_dtoa_fixed.o build/src/njs_str.o build/src/njs_strtod.o build/src/njs_murmur_hash.o build/src/njs_djb_hash.o build/src/njs_utf8.o build/src/njs_utf16.o build/src/njs_arr.o build/src/njs_rbtree.o build/src/njs_flathsh.o build/src/njs_trace.o build/src/njs_random.o build/src/njs_malloc.o build/src/njs_mp.o build/src/njs_sprintf.o build/src/njs_utils.o build/src/njs_chb.o build/src/njs_value.o build/src/njs_vm.o build/src/njs_vmcode.o build/src/njs_lexer.o build/src/njs_lexer_keyword.o build/src/njs_parser.o build/src/njs_variable.o build/src/njs_scope.o build/src/njs_generator.o build/src/njs_disassembler.o build/src/njs_module.o build/src/njs_extern.o build/src/njs_boolean.o build/src/njs_number.o build/src/njs_symbol.o build/src/njs_string.o build/src/njs_object.o build/src/njs_object_prop.o build/src/njs_array.o build/src/njs_json.o build/src/njs_function.o build/src/njs_regexp.o build/src/njs_date.o build/src/njs_error.o build/src/njs_math.o build/src/njs_array_buffer.o build/src/njs_typed_array.o build/src/njs_promise.o build/src/njs_encoding.o build/src/njs_iterator.o build/src/njs_async.o build/src/njs_builtin.o build/external/njs_regex.o build/src/njs_buffer.o build/external/njs_crypto_module.o build/external/njs_md5.o build/external/njs_sha1.o build/external/njs_sha2.o build/external/njs_webcrypto_module.o build/external/njs_fs_module.o build/external/njs_query_string_module.o build/build/njs_modules.o
+cc -Wl,-Bsymbolic-functions -flto=auto -ffat-lto-objects -Wl,-z,relro -Wl,-z,now -specs=/usr/share/dpkg/elf-package-metadata.specs -o build/njs -Isrc -Ibuild \
+ -pipe -fPIC -fvisibility=hidden -O -W -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wmissing-prototypes -Werror -g -fexcess-precision=standard -g -O3 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -flto=auto -ffat-lto-objects -fstack-protector-strong -Wformat -Werror=format-security -fno-stack-clash-protection -fdebug-prefix-map=/<<PKGBUILDDIR>>=/usr/src/libnginx-mod-js-0.8.4-1 -fPIC -Wdate-time -D_FORTIFY_SOURCE=3 -g -O3 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -flto=auto -ffat-lto-objects -fstack-protector-strong -Wformat -Werror=format-security -fno-stack-clash-protection -fdebug-prefix-map=/<<PKGBUILDDIR>>=/usr/src/libnginx-mod-js-0.8.4-1 \
+ external/njs_shell.c \
+ build/libnjs.a \
+ -Wl,-Bsymbolic-functions -flto=auto -ffat-lto-objects -Wl,-z,relro -Wl,-z,now -specs=/usr/share/dpkg/elf-package-metadata.specs -lm -lpcre2-8 -lcrypto -ledit
+In function ‘njs_utf8_decode’,
+ inlined from ‘njs_text_encoder_encode_into’ at src/njs_encoding.c:214:14:
+src/njs_utf8.c:191:42: error: ‘ctx.codepoint’ may be used uninitialized [-Werror=maybe-uninitialized]
+ 191 | ctx->codepoint = (ctx->codepoint << 6) | (c & 0x3F);
+ | ^
+src/njs_encoding.c: In function ‘njs_text_encoder_encode_into’:
+src/njs_encoding.c:169:27: note: ‘ctx.codepoint’ was declared here
+ 169 | njs_unicode_decode_t ctx;
+ | ^
+In function ‘njs_utf8_length’,
+ inlined from ‘njs_error_new’ at src/njs_error.c:39:14,
+ inlined from ‘njs_throw_error_va’ at src/njs_error.c:69:5:
+src/njs_utf8.h:141:12: error: ‘buf’ may be used uninitialized [-Werror=maybe-uninitialized]
+ 141 | return njs_utf8_stream_length(&ctx, p, len, 1, 1, NULL);
+ | ^
+src/njs_utf8.c: In function ‘njs_throw_error_va’:
+src/njs_utf8.c:354:1: note: by argument 2 of type ‘const u_char *’ to ‘njs_utf8_stream_length.constprop’ declared here
+ 354 | njs_utf8_stream_length(njs_unicode_decode_t *ctx, const u_char *p, size_t len,
+ | ^
+src/njs_error.c:61:14: note: ‘buf’ declared here
+ 61 | u_char buf[NJS_MAX_ERROR_STR], *p;
+ | ^
+lto1: all warnings being treated as errors
+make[3]: *** [/tmp/ccCzf1An.mk:32: /tmp/cc3U6GC7.ltrans10.ltrans.o] Error 1
+make[3]: *** Waiting for unfinished jobs....
+lto1: all warnings being treated as errors
+make[3]: *** [/tmp/ccCzf1An.mk:26: /tmp/cc3U6GC7.ltrans8.ltrans.o] Error 1
+lto-wrapper: fatal error: make returned 2 exit status
+compilation terminated.
+/usr/bin/ld: error: lto-wrapper failed
+collect2: error: ld returned 1 exit status
+---
+ src/njs_error.c | 2 +-
+ src/njs_utf8.h | 1 +
+ 2 files changed, 2 insertions(+), 1 deletion(-)
+
+diff --git a/src/njs_error.c b/src/njs_error.c
+index b1b62c89d..12d2d6bf0 100644
+--- a/src/njs_error.c
++++ b/src/njs_error.c
+@@ -58,7 +58,7 @@ void
+ njs_throw_error_va(njs_vm_t *vm, njs_object_t *proto, const char *fmt,
+ va_list args)
+ {
+- u_char buf[NJS_MAX_ERROR_STR], *p;
++ u_char buf[NJS_MAX_ERROR_STR] = {0}, *p;
+
+ p = buf;
+
+diff --git a/src/njs_utf8.h b/src/njs_utf8.h
+index ce4d86657..d074fc322 100644
+--- a/src/njs_utf8.h
++++ b/src/njs_utf8.h
+@@ -128,6 +128,7 @@ njs_utf8_decode_init(njs_unicode_decode_t *ctx)
+ {
+ ctx->need = 0x00;
+ ctx->lower = 0x00;
++ ctx->codepoint = 0x00;
+ }
+
+
diff -Nru libnginx-mod-js-0.8.4/debian/patches/series libnginx-mod-js-0.8.4/debian/patches/series
--- libnginx-mod-js-0.8.4/debian/patches/series 1970-01-01 01:00:00.000000000 +0100
+++ libnginx-mod-js-0.8.4/debian/patches/series 2024-06-15 15:53:23.000000000 +0200
@@ -0,0 +1 @@
+738.patch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-nginx-maintainers/attachments/20240615/7044a6da/attachment.sig>
More information about the Pkg-nginx-maintainers
mailing list