[pkg-nvidia-devel] Bug#523727: Bug#523727: nvidia-kernel-source: does not build against kernels older than 2.6.29

[Sven Joachim]

On 2009-04-13 23:58 +0200, Lennart Sorensen wrote:

> On Mon, Apr 13, 2009 at 10:51:57PM +0200, Sven Joachim wrote:
>> On 2009-04-13 20:54 +0200, Lennart Sorensen wrote:
>> 
>> > Well I have discovered that it should work with kernel.org kernels,
>> > but not with 2.6.27 and 2.6.28 as patched by debian.
>> 
>> Huh?  I _am_ using a kernel.org kernel.
>
> Well the sources I downloaded from kernel.org certainly appear that they
> should work based on the source code.  I didn't try them though.
>
> Did you look at your include/linux/smp.h for that function?  I would
> love to know what yours contains.

In 2.6.27 through 2.6.29, it's 

int smp_call_function(void(*func)(void *info), void *info, int wait);

> Perhaps I am looking at the wrong one.  It could be some architectures
> use their own variant somehow.  If so, changing the check to 2.6.27
> instead of 2.6.29 should fix it.

You mean like the following patch?

--8<---------------cut here---------------start------------->8---
--- conftest.h~	2009-04-13 07:43:50.000000000 +0200
+++ conftest.h	2009-04-14 08:50:30.980322038 +0200
@@ -160,7 +160,7 @@
 /* Only kernels sometime before 2.4.0 don't have this function, and who */
 /* cares anymore */
 #define NV_SMP_CALL_FUNCTION_PRESENT
-#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,29)
+#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,27)
  #define NV_SMP_CALL_FUNCTION_ARGUMENT_COUNT 3
 #else
  #define NV_SMP_CALL_FUNCTION_ARGUMENT_COUNT 4
--8<---------------cut here---------------end--------------->8---

That does indeed work for me. :-)

Sven