[pkg-nvidia-devel] [PATCH 1/2] [nvidia-graphics-modules-i386] cleanup

[Russ Allbery]

Andreas Beckmann <debian at abeckmann.de> writes:
> Russ Allbery wrote:
>> Andreas Beckmann <debian at abeckmann.de> writes:

>>>  * keep the original changelog from nvidia-kernel-source as
>>>    changelog.nvidia-kernel-source

>>> Now I just need to find a way to include this as an additional changelog
>>> while module-assistant builds the module package ... probably also a
>>> patch for nvidia-graphics-drivers.

>> I don't think we actually care about the nvidia-graphics-modules-*
>> changelog, since for the most part it isn't going to affect the
>> contents of those packages.  I wouldn't go to a lot of work to include
>> it in the kernel package.

> But we replace the much more interesting changelog from
> nvidia-graphics-modules with the boring one from
> nvidia-graphics-modules-* currently ...

Oh, right, sorry, I meant to explicitly say that I agreed with this hunk.
I was just commenting that the follow-on work you described probably
wasn't really necessary and that what you had here was enough.

> i386 and amd64 from one source should be not too difficult, but probably
> we still should have separate module builder packages for n-g-d and each
> n-g-d-legacy-abcxx

Could you say why that would be needed?  I don't see it (it's two
different source packages and the names shouldn't conflict), but I might
be missing something.

> For the short term, it would be nice to have -amd64 back

Yeah, I was going to work on that tonight or this weekend.

> Should I send a shorter patch only including the things you acked?

That would be great.

> PS: I just tried and successfully built modules for vserver-686 and
> vserver-686-bigmem, too. There is no way I could test them, but probably
> they should be added to the flavor list anyway. Having patch 2/2 that
> generates debian/control really helps here :-)

Oh, okay.  I can do that for the next round.

> PPS: I also successfully built amd64 and vserver-amd64 for the amd64
> arch by just updating debian/control.flavor to amd64 and using
> KERNELFLAVORS=amd64 vserver-amd64 in debian/rules.defs

Excellent!

Thank you very much for all your work here.  It's been extremely helpful.
It's fun to go apply pending patches that already do lots of cleanup.

-- 
Russ Allbery (rra at debian.org)               <http://www.eyrie.org/~eagle/>