[pkg-nvidia-devel] [patch 190xx] [18/k] remove long obsolete code from maintainer scripts

[Russ Allbery]

Andreas Beckmann <debian at abeckmann.de> writes:

> the attached patch removes a lot of old code from the maintainer scripts:

>  * maintainer scripts:
>    - synchronize with dh_make templates
>    - document the target release squeeze for some cleanup operations as
>      a hint to remove them after squeeze release
>    - remove code deactivated before etch release
>    - remove diversion transition and cleanup code introduced before etch
>      release
>    - remove libwfb.so diversion cleanup code introduced before lenny
>      release

> The patch is rather big because it is such a lot of crap being removed,
> but if you want, I can split into smaller pieces.

Thanks, applied, as this is way better than what we have now.

For the future, I really hate the dh_make templates for maintainer scripts
because they make the scripts fragile in the presence of any newly
introduced maintainer script options (such as, if I recall correctly, were
introduced with Breaks).  Maintainer scripts, IMO, should check for the
actions where they want to perform something (and seriously consider
whether they can just perform those actions unconditionally) only.  They
should not attempt to diagnose being called with unknown options; they
should just silently do nothing or silently do the default action if it
can be performed unconditionally.  This makes it way easier to introduce
new dpkg features in the whole archive.

I think in the long run we'll want to rip out all those case statements
and comments, therefore, in favor of something simpler.  But this is
certainly an improvement.

-- 
Russ Allbery (rra at debian.org)               <http://www.eyrie.org/~eagle/>