[Pkg-opencl-devel] New OpenCL Package - Oclgrind

[Andreas Beckmann]

On 2015-09-10 22:07, James Price wrote:
> Thanks. I’ve read this, but it’s still not entirely clear to me what the preferred package/SONAME version scheme is when upstream packages use date-based versioning:

There is no clear preference since that is usually upstream's choice.

> 1. Use upstream version numbers, with minor bugfix releases for maintaining the version in stable.
> 2. Introduce a Debian-specific version number that only updates when an upstream version introduces a breaking API change.

There are usually 2 cases frowned upon:
* upstreams making backwards incompatible changes without bumping the
soversion
* upstreams bumping the soname for no good reason (since that causes
extra work: it triggers a transition if there are any rdepends and also
requires a pass through NEW). But better save than sorry.

> I’m leaning towards option 1. at the moment (which is how the package is set-up at the moment), but would happy to move to 2. (or something else) if that would be preferred. I guess 1. is essentially the situation with the LLVM packages, which break the API with every release.

It shouldn't be impossible to switch the scheme at a later point, so
just see how the coming releases develop w.r.t. stability.
I primarily wanted to make you aware of the potential issues involved here.

>> the build is not reproducible since the *.pch are differing from run to run,
> 
> If the non-reproducibility is a show-stopper I can remove the PCH files from the package since they are optional. It just means the OpenCL kernel compilation times will be significantly longer.

Non-reproducibility is not a problem for introducing a new package,
especially since it is not trivial to fix. (Crippling the package is not
a good solution.)


debian/copyright misses some information
(licensecheck -r --copyright .)

./src/CL/*: MIT/X11 (BSD like)
  [Copyright: 2008-2013 The Khronos Group Inc]
(check the opencl-headers package for the license I used there)

your code is
// Copyright (c) 2013-2015, James Price and Simon McIntosh-Smith,
// University of Bristol. All rights reserved.

but debian/copyright only says
Copyright: 2013-2015 James Price <j.price at bristol.ac.uk>


The BSD-3-clause entry in d/copyright does not match LICENSE exactly:
(wdiff LICENSE debian/copyright):

3. Neither the name of the [-copyright holder-] {+University+} nor the
names of its contributors

 A PARTICULAR PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL THE [-COPYRIGHT
HOLDER-] {+HOLDERS+} OR


That's probably that last bits to criticize, thereafter we should be
ready for an initial upload.


Andreas