[Pkg-openldap-devel] r689 - in openldap/trunk-2.3/debian: . lintian-overrides

[Matthijs Mohlmann]

Author: active2-guest
Date: 2006-07-15 22:00:38 +0000 (Sat, 15 Jul 2006)
New Revision: 689

Modified:
   openldap/trunk-2.3/debian/lintian-overrides/slapd
   openldap/trunk-2.3/debian/slapd.scripts-common
Log:
 * Added a lintian override for insecure tmp file handling, we are using the
   perl function mkstemp.
 * Slightly improve the write_slapd_conf function.


Modified: openldap/trunk-2.3/debian/lintian-overrides/slapd
===================================================================
--- openldap/trunk-2.3/debian/lintian-overrides/slapd	2006-07-15 21:15:08 UTC (rev 688)
+++ openldap/trunk-2.3/debian/lintian-overrides/slapd	2006-07-15 22:00:38 UTC (rev 689)
@@ -10,3 +10,7 @@
 # The extended description is needed in slapd/backend. It explains a lot about
 # the different backends.
 slapd: too-long-extended-description-in-templates slapd/backend
+
+# Bug in lintian says insecure tmp file handling. While using the perl function
+# mkstemp.
+slapd: possibly-insecure-handling-of-tmp-files-in-maintainer-script

Modified: openldap/trunk-2.3/debian/slapd.scripts-common
===================================================================
--- openldap/trunk-2.3/debian/slapd.scripts-common	2006-07-15 21:15:08 UTC (rev 688)
+++ openldap/trunk-2.3/debian/slapd.scripts-common	2006-07-15 22:00:38 UTC (rev 689)
@@ -369,8 +369,7 @@
 
 		sub changeConfig {
 			my ($conf, $regexp) = @_;
-			my $template = "/tmp/tmp.XXXXXX";
-			my ($fh, $name) = mkstemp($template);
+			my ($fh, $name) = mkstemp("/tmp/tmp.XXXXXX");
 
 			open(HANDLE, "<". $conf) || return;
 			my @data = <HANDLE>;