[Pkg-openldap-devel] Bug#428883: bashism in init script fails to start slapd

[Thorsten Glaser]

Package: slapd
Version: 2.3.30-5
Severity: important
Tags: patch

Hi,

I've reported a similar bug to the sendmail-bin postinst script
some time ago, you'll find it at
| http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=424213
for reference and deeper information.

The script defines a shell function "stop()", however, all Korn
shells have "stop" defined as builtin alias (unalias would work,
but in the below patch, I've renamed the stop() function and,
for consistency, the start() function).

Maybe someone should scan all Debian packages for that issue.

I'd be appreciated if you apply the patch in a follow-up release,
as Debian Policy states that scripts beginning with #!/bin/sh must
be portable.

Thanks!

--- /etc/init.d/slapd	2007-06-14 19:50:50.000000000 +0000
+++ slapd.new	2007-06-14 21:47:11.000000000 +0000
@@ -177,7 +177,7 @@ stop_slurpd() {
 }
 
 # Start the OpenLDAP daemons
-start() {
+start_ldap() {
 	echo -n "Starting OpenLDAP:"
 	trap 'report_failure' 0
 	start_slapd
@@ -187,7 +187,7 @@ start() {
 }
 
 # Stop the OpenLDAP daemons
-stop() {
+stop_ldap() {
 	echo -n "Stopping OpenLDAP:"
 	trap 'report_failure' 0
 	stop_slurpd
@@ -198,12 +198,12 @@ stop() {
 
 case "$1" in
   start)
-  	start ;;
+  	start_ldap ;;
   stop)
-  	stop ;;
+  	stop_ldap ;;
   restart|force-reload)
-  	stop
-	start
+  	stop_ldap
+	start_ldap
 	;;
   *)
   	echo "Usage: $0 {start|stop|restart|force-reload}"



-- System Information:
Debian Release: 4.0
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/mksh
Kernel: Linux 2.6.18-4-k7
Locale: LANG=C, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)

Versions of packages slapd depends on:
ii  adduser                   3.102          Add and remove users and groups
ii  coreutils                 5.97-5.3       The GNU core utilities
ii  debconf [debconf-2.0]     1.5.11         Debian configuration management sy
ii  libc6                     2.3.6.ds1-13   GNU C Library: Shared libraries
ii  libdb4.2                  4.2.52+dfsg-2  Berkeley v4.2 Database Libraries [
ii  libiodbc2                 3.52.4-5       iODBC Driver Manager
ii  libldap-2.3-0             2.3.30-5       OpenLDAP libraries
ii  libltdl3                  1.5.22-4       A system independent dlopen wrappe
ii  libperl5.8                5.8.8-7        Shared Perl library
ii  libsasl2-2                2.1.22.dfsg1-8 Authentication abstraction library
ii  libslp1                   1.2.1-6.2      OpenSLP libraries
ii  libssl0.9.8               0.9.8c-4       SSL shared libraries
ii  libwrap0                  7.6.dbs-13     Wietse Venema's TCP wrappers libra
ii  perl [libmime-base64-perl 5.8.8-7        Larry Wall's Practical Extraction 
ii  psmisc                    22.3-1         Utilities that use the proc filesy

Versions of packages slapd recommends:
ii  libsasl2-modules          2.1.22.dfsg1-8 Pluggable Authentication Modules f

-- debconf information:
  slapd/password_mismatch:
  slapd/fix_directory: true
  slapd/invalid_config: true
* shared/organization: freewrt.org
  slapd/upgrade_slapcat_failure:
  slapd/upgrade_slapadd_failure:
  slapd/backend: BDB
* slapd/dump_database: when needed
* slapd/allow_ldap_v2: true
  slapd/no_configuration: false
  slapd/migrate_ldbm_to_bdb: false
  slapd/move_old_database: true
  slapd/suffix_change: false
  slapd/slave_databases_require_updateref:
* slapd/dump_database_destdir: /var/backups/slapd-VERSION
  slapd/autoconf_modules: true
  slapd/purge_database: false
* slapd/domain: freewrt.org