[Pkg-openldap-devel] back..

[Russ Allbery]

Quanah Gibson-Mount <quanah at stanford.edu> writes:

> I had a discussion with Russ, and I'm willing to give this a try again.

> I would really like to see the connection code issue in 2.3.30 be
> patched. A diff is available here:

> <http://www.openldap.org/devel/cvsweb.cgi/servers/slapd/connection.c.diff?hideattic=1&r1=text&tr1=1.296.2.21&r2=text&tr2=1.296.2.23&f=h>

> for the colored diff or

> <http://www.openldap.org/devel/cvsweb.cgi/servers/slapd/connection.c.diff?hideattic=1&r1=text&tr1=1.296.2.21&r2=text&tr2=1.296.2.23&f=c>

> for the context diff

> This particular issue plagued my servers for several months.  Without
> this fix, slapd will periodically segfault due to a race condition.

This patch looks fairly small and safe to me, but I'm not the one who
would have to bless it to get into the release.  Steve, opinions with your
release manager hat on?  Basically, it moves more of a checking operation
inside a mutex lock.

-- 
Russ Allbery (rra at debian.org)               <http://www.eyrie.org/~eagle/>