[Pkg-openldap-devel] back..

[Quanah Gibson-Mount]

--On Saturday, March 03, 2007 9:50 PM -0800 Steve Langasek 
<vorlon at debian.org> wrote:

> Hi guys,
>
> On Fri, Mar 02, 2007 at 05:29:21PM -0800, Russ Allbery wrote:
>> Quanah Gibson-Mount <quanah at stanford.edu> writes:
>
>> > I had a discussion with Russ, and I'm willing to give this a try again.
>
> Welcome back. :)

Thanks!

> The only thing I'm not clear on is why this particular check:
>
> +			if( connections[i].c_struct_state == SLAP_C_USED ) {
>
> is moved inside the mutex, given that there's another check against
> c_struct_state immediately preceding the mutex.

Well, because that is where the race condition was, IIRC. :)  It was 
possible for the connection to get into a state other than was expected 
without this section being protected by the mutex, and that was what caused 
my servers to segfault (I believe if the client closed the connection 
unexpectedly, but it has been a while).

--Quanah


--
Quanah Gibson-Mount
Principal Software Developer
ITS/Shared Application Services
Stanford University
GnuPG Public Key: http://www.stanford.edu/~quanah/pgp.html