[Pkg-openldap-devel] Bug#518657: Bug#518657: slapd: fix possible-bashism-in-maintainer-script lintian warning

Steve Langasek vorlon at debian.org
Sat Mar 7 19:11:29 UTC 2009


tags 518657 -patch
thanks

On Sat, Mar 07, 2009 at 07:25:31PM +0100, Peter Marschall wrote:
> --- debian/slapd.scripts-common
> +++ debian/slapd.scripts-common	2009-03-07 14:37:36.000000000 +0100
> @@ -632,7 +632,7 @@
>  	# For the domain really.argh.org we create the basedn 
>  	# dc=really,dc=argh,dc=org with the dc entry dc: really
>  	db_get slapd/domain
> -	local basedn="dc=`echo $RET | sed 's/^\.//; s/\./,dc=/g'`"
> +	basedn="dc=`echo $RET | sed 's/^\.//; s/\./,dc=/g'`"
>  	dc="`echo $RET | sed 's/^\.//; s/\..*$//'`"
>  
>  	db_get slapd/backend

This patch is wrong and should not be applied.  Variables used in functions
should be locally scoped, they just need to be declared in the manner
supported by policy.

-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                    http://www.debian.org/
slangasek at ubuntu.com                                     vorlon at debian.org





More information about the Pkg-openldap-devel mailing list