[Pkg-openldap-devel] r1259 - in openldap/trunk/debian: . patches

[Matthijs Mohlmann]

Hi Steve,

Thanks for the compliments but I'm not done yet, I want the new configuration style in
the package like ubuntu.

On Apr 19, 2010, at 1:17 AM, Steve Langasek wrote:

> Hi Matthijs,
> 
> Thanks for all your work to get the openldap package back on track!
> 
> On Sun, Apr 18, 2010 at 12:57:01PM +0000, matthijs at alioth.debian.org wrote:
>> Author: matthijs
>> Date: 2010-04-18 12:57:00 +0000 (Sun, 18 Apr 2010)
>> New Revision: 1259
> 
>> Added:
>>   openldap/trunk/debian/patches/smbk5pwd-makefile
>> Modified:
>>   openldap/trunk/debian/changelog
>>   openldap/trunk/debian/control
>>   openldap/trunk/debian/patches/series
>>   openldap/trunk/debian/rules
>> Log:
>> * Added smbk5pwd slapd module.
> 
> This doesn't seem to address the concerns raised in the bug report:
> 
> - This shouldn't be part of the main slapd package, it should be a separate
>   package (per Russ) to not pull heimdal in by default; Mark Hymers
>   provided a patch that did precisely this in
>   http://bugs.debian.org/cgi-bin/bugreport.cgi?msg=85;filename=smbk5pwd.diff;att=1;bug=443073
> 

Ok, that's something I misunderstood in the package. I made the decission more on
having one file in a separate package why not joining them. I'll work on that one.

> - There was a concern about interactions between OpenLDAP and GnuTLS
>   linkage which hasn't been addressed in the bug report.  I think the risk
>   here is minimal, but what testing has been done to ensure this?
> 

You mean the linking to both openssl and gnutls ? Now that the smbk5pwd module
has proper gnutls support, so no risk to get openssl as build dependency. Although
I can set libssl-dev as a build conflict then we're completely sure that OpenLDAP isn't
linked against openssl.

Regards,

Matthijs Mohlmann