[Pkg-openldap-devel] Bug#664930: Matthias' patch seems to be the correct action

[Peter Marschall]

Hi,

I have had a look at the changes in heimdal's upstream repo.

The change was introduced in commit
 https://github.com/heimdal/heimdal/commit/af011f57fc4ae6e865bab471c20aa9047e4e19d4
5 months ago and is based on another commit
 https://github.com/heimdal/heimdal/commit/6e04b05e9d8b76f74a130f1ce0819cd8d4f34d05
10 months ago.

Looking closer at  6e04b05e9d8b76f74a130f1ce0819cd8d4f34d05
one can see that even upstream uses the the values NULL and 0 for the two new 
arguments in the call to 
  hdb_generate_key_set()
from within
 hdb_generate_key_set_password().

Inside hdb_generate_key_set() there is logic to handle the fallback to default 
keytypes when the value NULL is passed for the argument ks_tuple.


Commit af011f57fc4ae6e865bab471c20aa9047e4e19d4 only exposes these new 
arguments in hdb_generate_key_set_password()'s argument list but keeps the 
internal logic in hdb_generate_key_set() when the value for the argument 
ks_tuple is NULL.

So I consider Matthias' patch correct

Best regards
PEter

PS: for me this patch made OpenLDAP 2.6.31 compile flawlessly.
 
-- 
Peter Marschall
peter at adpm.de