[Pkg-openldap-devel] Bug#905237: (ITS#8890) Bug fix patches unbreaking the build on x32 systems

Thorsten Glaser tg at debian.org
Tue Dec 18 23:21:45 GMT 2018


Howard Chu dixit:

>The remaining format patches for debug statements will have no impact
>on the correctness of execution or output. This and all of the
>following patches are being rejected.

There are multiple systems on which sizeof(time_t) > sizeof(long),
with more expected as 2038 dawns.

Are you saying you want to prohibit users on these platforms from
debugging OpenLDAP?

>> --- a/contrib/slapd-modules/smbk5pwd/smbk5pwd.c
>> +++ b/contrib/slapd-modules/smbk5pwd/smbk5pwd.c
>> @@ -605,7 +605,7 @@ static int smbk5pwd_exop_passwd(
>>  		keys[0].bv_val = ch_malloc( LDAP_PVT_INTTYPE_CHARS(long) );
>>  		keys[0].bv_len = snprintf(keys[0].bv_val,
>>  			LDAP_PVT_INTTYPE_CHARS(long),
>> -			"%ld", slap_get_time());
>> +			"%lld", (long long)slap_get_time());
>>  		BER_BVZERO( &keys[1] );

This doesn’t look like debugging output to me.

bye,
//mirabilos
-- 
Yes, I hate users and I want them to suffer.
	-- Marco d'Itri on gmane.linux.debian.devel.general



More information about the Pkg-openldap-devel mailing list