[Pkg-openldap-devel] Bug#905237: (ITS#8890) Bug fix patches unbreaking the build on x32 systems

Thorsten Glaser tg at mirbsd.de
Wed Dec 19 00:29:26 GMT 2018


Howard Chu dixit:

>This patch of yours *introduces a bug*. If you wanted to actually *fix*
>something you should have made sure the malloc'd buffer - which only happens
>2 lines above the lines you change - was large enough to store a long long.

That’s not a new bug, then.

That’s a completely separate Y2038 issue of *yours* that
will happen on all platforms, and has nothing to do with
long vs. long long, since a long on an LP64 platform *is*
already as wide as a long long.

In addition to that, use of snprintf will prevent this
from being worse than a mere truncation.

bye,
//mirabilos
-- 
Solange man keine schmutzigen Tricks macht, und ich meine *wirklich*
schmutzige Tricks, wie bei einer doppelt verketteten Liste beide
Pointer XORen und in nur einem Word speichern, funktioniert Boehm ganz
hervorragend.		-- Andreas Bogk über boehm-gc in d.a.s.r



More information about the Pkg-openldap-devel mailing list